Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2906043002: Revert of Redirecting off-origin navigations in PWAs to CCT. (Closed)

Created:
3 years, 6 months ago by Guido Urdaneta
Modified:
3 years, 6 months ago
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Redirecting off-origin navigations in PWAs to CCT. (patchset #17 id:640001 of https://codereview.chromium.org/2829943002/ ) Reason for revert: Suspect of breaking Android Tests bot. First failure: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/42115 Will reland if the revert does not fix the bot. Original issue's description: > Redirects off-origin navigations in an installed PWAs to a CustomTab. > > This is done in order to improve UX by getting rid of a "minibar" toolbar > (to be done in a follow-up patch) and bring more app-like feel to PWAs. > > In a long run this will help bring implementation of Minimal-UI, which requires > replacing "minibar" with a new "minimal-ui" toolbar. > > BUG=709889 > > Review-Url: https://codereview.chromium.org/2829943002 > Cr-Original-Commit-Position: refs/heads/master@{#474625} > Committed: https://chromium.googlesource.com/chromium/src/+/7c7e9e600d256af4d2af1dbf68b59b030be0ab25 > Review-Url: https://codereview.chromium.org/2829943002 > Cr-Commit-Position: refs/heads/master@{#474953} > Committed: https://chromium.googlesource.com/chromium/src/+/4c271c0deaf103d5612078b3d0d81847819c5d52 TBR=dominickn@chromium.org,yusufo@chromium.org,pkotwicz@chromium.org,tedchoc@chromium.org,piotrs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=709889 Review-Url: https://codereview.chromium.org/2906043002 Cr-Commit-Position: refs/heads/master@{#474976} Committed: https://chromium.googlesource.com/chromium/src/+/0ed1a20ddb4f1e7020211d3328150d56fdda21a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -391 lines) Patch
M chrome/android/java/AndroidManifest.xml View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInterceptNavigationDelegate.java View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 1 chunk +13 lines, -11 lines 0 comments Download
M chrome/android/java_sources.gni View 3 chunks +0 lines, -3 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TopActivityListener.java View 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java View 5 chunks +3 lines, -45 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestRule.java View 2 chunks +4 lines, -11 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java View 1 chunk +0 lines, -171 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/contextmenu/ContextMenuUtils.java View 3 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Guido Urdaneta
Created Revert of Redirecting off-origin navigations in PWAs to CCT.
3 years, 6 months ago (2017-05-26 09:51:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906043002/1
3 years, 6 months ago (2017-05-26 09:51:30 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 09:52:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ed1a20ddb4f1e7020211d332815...

Powered by Google App Engine
This is Rietveld 408576698