Worklet: Add layout tests for module import statements on WorkletGlobalScope

Worklet: Add layout tests for module import statements on WorkletGlobalScope

BUG=627945
Review-Url: https://codereview.chromium.org/2906013002
Cr-Commit-Position: refs/heads/master@{#474916}
Committed: https://chromium.googlesource.com/chromium/src/+/6cceae4b9017cb225d18775b0ac27b27fce45041

[nhiroki, 2017-05-26 02:25:06]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 02:26:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-05-26 02:27:53]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org, kinuko@chromium.org, kouhei@chromium.org

[nhiroki, 2017-05-26 02:27:54]

falken@ or kinuko@: Can you review this? kouhei@ is now flying in the sky :)

[commit-bot: I haz the power, 2017-05-26 04:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 04:34:02]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-05-26 04:47:23]

lgtm

[falken, 2017-05-26 04:52:39]

Just to be sure, is this not a WPT test because it requires paint worklet which
requires chrome internals to test?

I've discovered it's a huge effort to first land everything in chrome layout
tests and then port to WPT tests, so it'd be good if there's a plan to migrate
to WPT tests sooner than later.

[falken, 2017-05-26 04:55:35]

(this change itself lgtm)

[nhiroki, 2017-05-26 05:08:21]

On 2017/05/26 04:52:39, falken wrote:
> Just to be sure, is this not a WPT test because it requires paint worklet
which
> requires chrome internals to test?
> 
> I've discovered it's a huge effort to first land everything in chrome layout
> tests and then port to WPT tests, so it'd be good if there's a plan to migrate
> to WPT tests sooner than later.

Tests for PaintWorklet itself under "http/tests/csspaint/" need the chrome
internals, but tests for the Worklet core (e.g., Worklet.addModule()) under
"http/tests/worklet" don't need it.

I have a plan to upstream "http/tests/worklet" to WPT [1], but it's now blocked
by the spec discussion[2] (moving window.paintWorklet to CSS.paintWorklet).
After it's resolved, I'll start upstreaming them.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=724907
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=719303

[nhiroki, 2017-05-26 05:09:13]

... and thank you for reviewing this :)

[nhiroki, 2017-05-26 05:09:22]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:10:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:14:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495775362786330,
"parent_rev": "c99b85c688dad6fa669e73f147b6d74165c7ffd4", "commit_rev":
"6cceae4b9017cb225d18775b0ac27b27fce45041"}

[commit-bot: I haz the power, 2017-05-26 05:15:12]

Description was changed from

==========
Worklet: Add layout tests for module import statements on WorkletGlobalScope

BUG=627945
==========

to

==========
Worklet: Add layout tests for module import statements on WorkletGlobalScope

BUG=627945

Review-Url: https://codereview.chromium.org/2906013002
Cr-Commit-Position: refs/heads/master@{#474916}
Committed:
https://chromium.googlesource.com/chromium/src/+/6cceae4b9017cb225d18775b0ac2...
==========

[commit-bot: I haz the power, 2017-05-26 05:15:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6cceae4b9017cb225d18775b0ac2...