Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: chrome/browser/profiles/profile_manager.cc

Issue 2905903002: Delete the PreferenceMACs on profile deletion. (Closed)
Patch Set: Bring back plumbing solution, address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/prefs/in_memory_pref_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_manager.cc
diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc
index 5f2317b7c992597829e7e6a8f91f739b4878e8ca..599195a7bb8e21869952fe15e9de32a8bfe8c9b1 100644
--- a/chrome/browser/profiles/profile_manager.cc
+++ b/chrome/browser/profiles/profile_manager.cc
@@ -1510,6 +1510,9 @@ void ProfileManager::FinishDeletingProfile(
// The Profile Data doesn't get wiped until Chrome closes. Since we promised
// that the user's data would be removed, do so immediately.
profiles::RemoveBrowsingDataForProfile(profile_dir);
+
+ // Clean-up pref data that won't be cleaned up by NukeProfileFromDisk.
+ profile->GetPrefs()->OnStoreDeletionFromDisk();
} else {
// It is safe to delete a not yet loaded Profile from disk.
gab 2017/06/06 14:48:26 The logic will go through here if the user deletes
proberge 2017/06/07 19:22:50 Done. Note that this involves added complexity to
BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
« no previous file with comments | « no previous file | components/prefs/in_memory_pref_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698