Delete the PreferenceMACs on profile deletion.

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <stdint.h>
 
 #include <map>
 #include <set>
@@ skipping 1492 matching lines @@
         PasswordStoreFactory::GetForProfile(
             profile, ServiceAccessType::EXPLICIT_ACCESS).get();
     if (password_store.get()) {
       password_store->RemoveLoginsCreatedBetween(
           base::Time(), base::Time::Max(), base::Closure());
     }
 
     // The Profile Data doesn't get wiped until Chrome closes. Since we promised
     // that the user's data would be removed, do so immediately.
     profiles::RemoveBrowsingDataForProfile(profile_dir);
+
+    // Clean-up pref data that won't be cleaned up by NukeProfileFromDisk.
+    profile->GetPrefs()->OnStoreDeletionFromDisk();
   } else {
     // It is safe to delete a not yet loaded Profile from disk.

[gab, 2017/06/06 14:48:26]

The logic will go through here if the user deletes a profile from
chrome://settings without loading it. We need to support that use case too.

[proberge, 2017/06/07 19:22:50]

Done. Note that this involves added complexity to try to load the profile in
order to call OnStoreDeletionFromDisk. Clearing the registry will still fail if
the profile can't be loaded. 

Loading the the profile might be working against the todo for
https://bugs.chromium.org/p/chromium/issues/detail?id=88586.

In practice, I couldn't get this branch to be hit when removing a profile on
Windows. When trying to remove a profile, the UI displays some stats (This will
permanently delete N items from your device.) which require loading the profile.

     BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
                             base::BindOnce(&NukeProfileFromDisk, profile_dir));
   }
 
   // Queue even a profile that was nuked so it will be MarkedForDeletion and so
   // CreateProfileAsync can't create it.
   MarkProfileDirectoryForDeletion(profile_dir);
   storage.RemoveProfile(profile_dir);
   ProfileMetrics::UpdateReportedProfilesStatistics(this);
 }
@@ skipping 256 matching lines @@
 
   const base::FilePath new_active_profile_dir =
       found_entry ? found_entry->GetPath() : GenerateNextProfileDirectoryPath();
   FinishDeletingProfile(profile_dir, new_active_profile_dir);
 }
 #endif  // !defined(OS_ANDROID)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }