Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2905873003: VR: Disable select element in VR mode via WebPreferences (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index c530e82bde81dccf45383e65a34b7626352b1f6f..316410d15e8d993b5422b6898f2923b4251959b7 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -932,6 +932,10 @@ bool ChromeClientImpl::HasOpenedPopup() const {
PopupMenu* ChromeClientImpl::OpenPopupMenu(LocalFrame& frame,
HTMLSelectElement& select) {
NotifyPopupOpeningObservers();
+
+ if (frame.GetDocument()->GetSettings()->GetPagePopupsSuppressed())
Rick Byers 2017/05/25 21:06:17 nit: in vollick's previous CL he bailed out before
asimjour 2017/05/25 22:47:32 Done.
+ return nullptr;
+
if (WebViewBase::UseExternalPopupMenus())
return new ExternalPopupMenu(frame, select, *web_view_);

Powered by Google App Engine
This is Rietveld 408576698