Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2905843003: WebVR: use optimized render path with deferred wait (Closed)

Created:
3 years, 6 months ago by klausw
Modified:
3 years, 6 months ago
Reviewers:
bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR: use optimized render path with deferred wait Now that the synchronization issue (occasional black screen flashes) that affected the optimized render path is fixed (see issue 723962 and crrev.com/2891033002 / r473687), switch to that implementation and remove the old code path. BUG=726374 Review-Url: https://codereview.chromium.org/2905843003 Cr-Commit-Position: refs/heads/master@{#474733} Committed: https://chromium.googlesource.com/chromium/src/+/89f6d708d1be7d2c1cebaa74b11908740130f617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -27 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 3 chunks +8 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
klausw
3 years, 6 months ago (2017-05-25 17:15:58 UTC) #2
bajones
On 2017/05/25 17:15:58, klausw wrote: LGTM!
3 years, 6 months ago (2017-05-25 17:17:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905843003/1
3 years, 6 months ago (2017-05-25 17:20:55 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-05-25 18:57:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/89f6d708d1be7d2c1cebaa74b119...

Powered by Google App Engine
This is Rietveld 408576698