Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2905783002: Rename SendContextMenuEventForKey to ShowNonLocatedContextMenu (Closed)

Created:
3 years, 7 months ago by amaralp
Modified:
3 years, 7 months ago
Reviewers:
bokan, amaralp1
CC:
blink-reviews, chromium-reviews, dtapuska+blinkwatch_chromium.org, kinuko+watch, Navid Zolghadr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SendContextMenuEventForKey to ShowNonLocatedContextMenu SendContextMenuEventForKey is being used for things other than key events. This new name is more descriptive of what it does. Review-Url: https://codereview.chromium.org/2905783002 Cr-Commit-Position: refs/heads/master@{#474627} Committed: https://chromium.googlesource.com/chromium/src/+/fd9e94be64898b22c757a5c0567ac8bb396e5ed9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/menu-key-context-menu-document-pinch-zoom.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
amaralp1
PTAL
3 years, 7 months ago (2017-05-25 07:15:53 UTC) #6
bokan
lgtm
3 years, 7 months ago (2017-05-25 11:25:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905783002/1
3 years, 7 months ago (2017-05-25 11:26:07 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 11:30:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd9e94be64898b22c757a5c0567a...

Powered by Google App Engine
This is Rietveld 408576698