third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2905733003: Remove WTFLogAlways() usages from core/layout/

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2905733003: Remove WTFLogAlways() usages from core/layout/

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index df0849ba475e947a4d79aa3ae87cb6e52fc76d45..45db44693d549ed0286fe643e1e7f6770b862d60 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -1355,10 +1355,11 @@ void LayoutObject::ShowLayoutObject(StringBuilder& string_builder) const {

while (string_builder.length() < kShowTreeCharacterOffset)

string_builder.Append(' ');

string_builder.Append('\t');

- WTFLogAlways("%s%s", string_builder.ToString().Utf8().data(),

- GetNode()->ToString().Utf8().data());

+ LOG(INFO) << "\n"

fs 2017/06/14 20:14:19 Why an initial \n (WTFLogAlways always made sure t

tkent 2017/06/14 23:41:39 ShowLayoutObject() is one-line summary of this Lay

mrunal 2017/06/19 22:10:57 @fs, No idea, I was just trying to follow other pa

mrunal 2017/06/19 22:10:57 @tkent, so just overload operator<<() instead of S

tkent 2017/06/20 02:36:23 Yes, I meant it. However, I realized it was unnece

+ << string_builder.ToString().Utf8().data()

fs 2017/06/14 20:14:19 Don't we have an operator<< that would work here?

mrunal 2017/06/19 22:10:57 Again, I was just trying to follow other patches w

tkent 2017/06/20 02:36:24 |<< string_builder.ToString()| and |<< string_buil

fs 2017/06/20 08:24:35 I don't particularly care either way, but I don't

+ << GetNode()->ToString().Utf8().data();

} else {

- WTFLogAlways("%s", string_builder.ToString().Utf8().data());

+ LOG(INFO) << "\n" << string_builder.ToString().Utf8().data();

mstensho (USE GERRIT) 2017/06/20 08:49:40 Changing from WTFLogAlways() to LOG() introduces a

}

@@ -3622,14 +3623,14 @@ void showTree(const blink::LayoutObject* object) {

if (object)

object->ShowTreeForThis();

else

- WTFLogAlways("%s", "Cannot showTree. Root is (nil)");

+ LOG(INFO) << "\n Cannot showTree. Root is (nil)";

tkent 2017/06/14 23:41:39 The leading "\n" is unnecessary.

tkent 2017/06/14 23:41:40 The leading "\n" is unnecessary.

mrunal 2017/06/19 22:10:57 Acknowledged.

}

void showLineTree(const blink::LayoutObject* object) {

if (object)

object->ShowLineTreeForThis();

else

- WTFLogAlways("%s", "Cannot showLineTree. Root is (nil)");

+ LOG(INFO) << "\n Cannot showLineTree. Root is (nil)";

tkent 2017/06/14 23:41:39 The leading "\n" is unnecessary.

mrunal 2017/06/19 22:10:57 Acknowledged.

}

void showLayoutTree(const blink::LayoutObject* object1) {

@@ -3644,7 +3645,7 @@ void showLayoutTree(const blink::LayoutObject* object1,

root = root->Parent();

root->ShowLayoutTreeAndMark(object1, "*", object2, "-", 0);

} else {

- WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");

+ LOG(INFO) << "\n Cannot showLayoutTree. Root is (nil)";

tkent 2017/06/14 23:41:39 The leading "\n" is unnecessary.

mrunal 2017/06/19 22:10:57 Acknowledged.

}

« third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp ('k') | no next file » | no next file with comments »