Remove WTFLogAlways() usages from core/layout/

third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp

Index: third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp b/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
index bc3df43e016333d71bec27f783beba12ff583776..181c52409ef348b0b25db380574d9783f775a46a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
@@ -30,14 +30,6 @@
 #include "platform/geometry/TransformState.h"
 #include "platform/wtf/AutoReset.h"
 
-#define LAYOUT_GEOMETRY_MAP_LOGGING 0

[fs, 2017/06/14 20:14:19]

"...as the code is unmaintainable."

I'm not sure I understand this statement. I don't see the "unmaintainable" bit
here. I don't particularly mind removing this debugging code, but I also didn't
add it... So, could we have a better reason for removing it? (And, tangentially,
there's a typo LayoutGeomteryMap in the same sentence in the description.)

[mrunal, 2017/06/19 22:10:57]

The unmaintainable bit is below where LAYOUT_GEOMETRY_MAP_LOG is used. The
variable references in LAYOUT_GEOMETRY_MAP_LOG are not compile checked so if
their definitions change over time it's hard to keep that code up to date.
I will correct the LayoutGeomteryMap.cpp to LayoutGeometryMap.cpp in the
description.

[fs, 2017/06/20 08:24:35]

Yes, sure, but that is pretty much the burden of having this code checked in in
the first place...

-
-#if LAYOUT_GEOMETRY_MAP_LOGGING
-#define LAYOUT_GEOMETRY_MAP_LOG(...) WTFLogAlways(__VA_ARGS__)

[tkent, 2017/06/14 23:41:39]

Such conditional log macros is usually replaced with DVLOG().

-#else
-#define LAYOUT_GEOMETRY_MAP_LOG(...) ((void)0)
-#endif
-
 namespace blink {
 
 LayoutGeometryMap::LayoutGeometryMap(MapCoordinatesFlags flags)
@@ -239,11 +231,6 @@ void LayoutGeometryMap::PushMappingsToAncestor(
                                        ancestor_layer->GetLayoutObject())
           : false;
 
-  LAYOUT_GEOMETRY_MAP_LOG(
-      "LayoutGeometryMap::pushMappingsToAncestor from layer %p to layer %p, "
-      "canConvertInLayerTree=%d\n",
-      layer, ancestorLayer, canConvertInLayerTree);
-
   if (can_convert_in_layer_tree) {
     LayoutPoint layer_offset;
     layer->ConvertToLayerCoords(ancestor_layer, layer_offset);
@@ -271,10 +258,6 @@ void LayoutGeometryMap::Push(const LayoutObject* layout_object,
                              const LayoutSize& offset_from_container,
                              GeometryInfoFlags flags,
                              LayoutSize offset_for_fixed_position) {
-  LAYOUT_GEOMETRY_MAP_LOG("LayoutGeometryMap::push %p %d,%d isNonUniform=%d\n",
-                          layoutObject, offsetFromContainer.width().toInt(),

[mrunal, 2017/06/19 22:10:57]

@fs, For example there is no definition for offsetFromContainer now as it has
changed. Things like these are unmaintainable if it cannot be checked compile
time.

-                          offsetFromContainer.height().toInt(), isNonUniform);
-
   DCHECK_NE(insertion_position_, kNotFound);
   DCHECK(!layout_object->IsLayoutView() || !insertion_position_ ||
          map_coordinates_flags_ & kTraverseDocumentBoundaries);