Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4029)

Unified Diff: components/translate/core/browser/translate_manager.h

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Inlining the DidNavigate function Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_manager.h
diff --git a/components/translate/core/browser/translate_manager.h b/components/translate/core/browser/translate_manager.h
index c29b167775b106075f813a3bf79558a8dd437e2a..c2c2d88d480f4d55a8282c6ac3839a1fb7a70bc2 100644
--- a/components/translate/core/browser/translate_manager.h
+++ b/components/translate/core/browser/translate_manager.h
@@ -13,6 +13,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "components/translate/core/browser/language_state.h"
#include "components/translate/core/common/translate_errors.h"
class GURL;
@@ -22,6 +23,12 @@ class TranslateDriver;
class TranslatePrefs;
struct TranslateErrorDetails;
+namespace content {
+struct LoadCommittedDetails;
+class NavigationController;
+class WebContents;
+}
droger 2014/05/20 07:43:07 Remove all these declarations.
nshaik 2014/05/20 22:33:53 Done.
+
// The TranslateManager class is responsible for showing an info-bar when a page
// in a language different than the user language is loaded. It triggers the
// page translation the user requests.
@@ -88,6 +95,8 @@ class TranslateManager {
static scoped_ptr<TranslateErrorCallbackList::Subscription>
RegisterTranslateErrorCallback(const TranslateErrorCallback& callback);
+ LanguageState& GetLanguageState();
+
private:
// Sends a translation request to the TranslateDriver.
void DoTranslatePage(const std::string& translate_script,
@@ -108,6 +117,8 @@ class TranslateManager {
TranslateClient* translate_client_; // Weak.
TranslateDriver* translate_driver_; // Weak.
+ LanguageState language_state_;
+
base::WeakPtrFactory<TranslateManager> weak_method_factory_;
DISALLOW_COPY_AND_ASSIGN(TranslateManager);

Powered by Google App Engine
This is Rietveld 408576698