components/translate/core/browser/translate_driver.h - Issue 290573013: LanguageState should be owned by TranslateManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_driver.h

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Inlining the DidNavigate function Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/translate_driver.h

diff --git a/components/translate/core/browser/translate_driver.h b/components/translate/core/browser/translate_driver.h

index 88bb50385390f036d535a59f401769372c493095..0cbb045ef16b421c69da03145db7c29599495f4d 100644

--- a/components/translate/core/browser/translate_driver.h

+++ b/components/translate/core/browser/translate_driver.h

@@ -24,9 +24,6 @@ class TranslateDriver {

// Called when the page is "translated" state of the page changed.

virtual void OnIsPageTranslatedChanged() = 0;

- // Gets the LanguageState associated with the driver.

- virtual LanguageState& GetLanguageState() = 0;

// Translates the page contents from |source_lang| to |target_lang|.

virtual void TranslatePage(const std::string& translate_script,

const std::string& source_lang,