Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: components/translate/content/browser/content_translate_driver.cc

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Inlining the DidNavigate function Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/content/browser/content_translate_driver.cc
diff --git a/components/translate/content/browser/content_translate_driver.cc b/components/translate/content/browser/content_translate_driver.cc
index 6d8ec5ff0d6d941b0918471e43c9a1871bc4f6e0..2f7431e45a7cc2ab44ee9b6ece335e33096f4e57 100644
--- a/components/translate/content/browser/content_translate_driver.cc
+++ b/components/translate/content/browser/content_translate_driver.cc
@@ -17,22 +17,12 @@
ContentTranslateDriver::ContentTranslateDriver(
content::NavigationController* nav_controller)
: navigation_controller_(nav_controller),
- language_state_(this),
observer_(NULL) {
DCHECK(navigation_controller_);
}
ContentTranslateDriver::~ContentTranslateDriver() {}
-void ContentTranslateDriver::DidNavigate(
- const content::LoadCommittedDetails& details) {
- const bool reload =
- details.entry->GetTransitionType() == content::PAGE_TRANSITION_RELOAD ||
- details.type == content::NAVIGATION_TYPE_SAME_PAGE;
- language_state_.DidNavigate(
- details.is_in_page, details.is_main_frame, reload);
-}
-
// TranslateDriver methods
bool ContentTranslateDriver::IsLinkNavigation() {
@@ -57,10 +47,6 @@ void ContentTranslateDriver::OnIsPageTranslatedChanged() {
}
}
-LanguageState& ContentTranslateDriver::GetLanguageState() {
- return language_state_;
-}
-
void ContentTranslateDriver::TranslatePage(const std::string& translate_script,
const std::string& source_lang,
const std::string& target_lang) {

Powered by Google App Engine
This is Rietveld 408576698