Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: components/translate/core/browser/translate_ui_delegate.h

Issue 290573013: LanguageState should be owned by TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tested for asan issue on linux Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ui_delegate.h
diff --git a/components/translate/core/browser/translate_ui_delegate.h b/components/translate/core/browser/translate_ui_delegate.h
index ab6986e3f32619b8452bc7f2b440e23eb296d26b..48eb5869b9f845edaf6e80b234a23de9661af850 100644
--- a/components/translate/core/browser/translate_ui_delegate.h
+++ b/components/translate/core/browser/translate_ui_delegate.h
@@ -10,6 +10,7 @@
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "components/translate/core/common/translate_errors.h"
@@ -26,7 +27,7 @@ class TranslateUIDelegate {
enum { NO_INDEX = -1, };
TranslateUIDelegate(TranslateClient* translate_client,
droger 2014/06/05 08:36:35 Optional cleanup while you are here: 1) remove the
nshaik 2014/06/05 18:45:30 Done.
- TranslateManager* translate_manager,
+ const base::WeakPtr<TranslateManager>& translate_manager,
const std::string& original_language,
const std::string& target_language);
virtual ~TranslateUIDelegate();
@@ -100,7 +101,7 @@ class TranslateUIDelegate {
TranslateClient* translate_client_;
TranslateDriver* translate_driver_;
- TranslateManager* translate_manager_;
+ base::WeakPtr<TranslateManager> translate_manager_;
typedef std::pair<std::string, base::string16> LanguageNamePair;

Powered by Google App Engine
This is Rietveld 408576698