LanguageState should be owned by TranslateManager

components/translate/core/browser/translate_ui_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_UI_DELEGATE_H_
 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_UI_DELEGATE_H_
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "components/translate/core/common/translate_errors.h"
 
 class LanguageState;
 class TranslateClient;
 class TranslateDriver;
 class TranslateManager;
 class TranslatePrefs;
 
 // The TranslateUIDelegate is a generic delegate for UI which offers Translate
 // feature to the user.
 class TranslateUIDelegate {
  public:
   enum { NO_INDEX = -1, };
 
   TranslateUIDelegate(TranslateClient* translate_client,

[droger, 2014/06/05 08:36:35]

Optional cleanup while you are here:
1) remove the translate_client parameter, and get it from the manager (there is
a translate_client() method on the manager).
2) remove the translate_client_ member, it is not actually used.

[nshaik, 2014/06/05 18:45:30]

Done.

-                      TranslateManager* translate_manager,
+                      const base::WeakPtr<TranslateManager>& translate_manager,
                       const std::string& original_language,
                       const std::string& target_language);
   virtual ~TranslateUIDelegate();
 
   // Handles when an error message is shown.
   void OnErrorShown(TranslateErrors::Type error_type);
 
   // Returns the LanguageState associated with this object.
   const LanguageState& GetLanguageState();
 
@@ skipping 53 matching lines @@
   // translated into the current target language automatically.
   void SetAlwaysTranslate(bool value);
 
  private:
   // Gets the host of the page being translated, or an empty string if no URL is
   // associated with the current page.
   std::string GetPageHost();
 
   TranslateClient* translate_client_;
   TranslateDriver* translate_driver_;
-  TranslateManager* translate_manager_;
+  base::WeakPtr<TranslateManager> translate_manager_;
 
   typedef std::pair<std::string, base::string16> LanguageNamePair;
 
   // The list supported languages for translation.
   // The pair first string is the language ISO code (ex: en, fr...), the second
   // string is the displayable name on the current locale.
   // The languages are sorted alphabetically based on the displayable name.
   std::vector<LanguageNamePair> languages_;
 
   // The index for language the page is originally in.
   size_t original_language_index_;
 
   // The index for language the page is originally in that was originally
   // reported (original_language_index_ changes if the user selects a new
   // original language, but this one does not).  This is necessary to report
   // language detection errors with the right original language even if the user
   // changed the original language.
   size_t initial_original_language_index_;
 
   // The index for language the page should be translated to.
   size_t target_language_index_;
 
   // The translation related preferences.
   scoped_ptr<TranslatePrefs> prefs_;
 
   DISALLOW_COPY_AND_ASSIGN(TranslateUIDelegate);
 };
 
 #endif  // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_UI_DELEGATE_H_