content/common/gpu/client/gpu_memory_buffer_impl_android.cc - Issue 290573011: Delay the response to ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer via a callback to allow for b…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_android.cc

Issue 290573011: Delay the response to ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer via a callback to allow for b… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/gpu_memory_buffer_impl.h ('K') | « content/common/gpu/client/gpu_memory_buffer_impl.h ('k') | content/common/gpu/client/gpu_memory_buffer_impl_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_android.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_android.cc b/content/common/gpu/client/gpu_memory_buffer_impl_android.cc

index 0e31dc9b65f31dc140d00887a2928258e214dafa..8e44b98afdc2eed323b93966448e60f6e6f10f98 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_android.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_android.cc

@@ -33,15 +33,16 @@ void GpuMemoryBufferImpl::AllocateForChildProcess(

unsigned internalformat,

unsigned usage,

base::ProcessHandle child_process,

- gfx::GpuMemoryBufferHandle* handle) {

+ gfx::GpuMemoryBufferHandle* handle,

+ const base::Closure& allocate_callback) {

+ handle->type = gfx::EMPTY_BUFFER;

if (GpuMemoryBufferImplShm::IsConfigurationSupported(

size, internalformat, usage)) {

GpuMemoryBufferImplShm::AllocateSharedMemoryForChildProcess(

size, internalformat, child_process, handle);

- return;

}

- handle->type = gfx::EMPTY_BUFFER;

+ allocate_callback.Run();

reveman 2014/05/19 05:51:07 I think it'd be better to forward the responsibili

}

// static