Delay the response to ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer via a callback to allow for b…

content/common/gpu/client/gpu_memory_buffer_impl_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl_shm.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h"
 
 namespace content {
@@ skipping 15 matching lines @@
 
   return scoped_ptr<GpuMemoryBufferImpl>();
 }
 
 // static
 void GpuMemoryBufferImpl::AllocateForChildProcess(
     const gfx::Size& size,
     unsigned internalformat,
     unsigned usage,
     base::ProcessHandle child_process,
-    gfx::GpuMemoryBufferHandle* handle) {
+    gfx::GpuMemoryBufferHandle* handle,
+    const base::Closure& allocate_callback) {
+  handle->type = gfx::EMPTY_BUFFER;
   if (GpuMemoryBufferImplShm::IsConfigurationSupported(
           size, internalformat, usage)) {
     GpuMemoryBufferImplShm::AllocateSharedMemoryForChildProcess(
         size, internalformat, child_process, handle);
-    return;
   }
 
-  handle->type = gfx::EMPTY_BUFFER;
+  allocate_callback.Run();

[reveman, 2014/05/19 05:51:07]

I think it'd be better to forward the responsibility to run this callback to the
implementation and make it transparent to this function whether it's sync or
async. 

 }
 
 // static
 scoped_ptr<GpuMemoryBufferImpl> GpuMemoryBufferImpl::CreateFromHandle(
     gfx::GpuMemoryBufferHandle handle,
     const gfx::Size& size,
     unsigned internalformat) {
   switch (handle.type) {
     case gfx::SHARED_MEMORY_BUFFER: {
       scoped_ptr<GpuMemoryBufferImplShm> buffer(
@@ skipping 10 matching lines @@
         return scoped_ptr<GpuMemoryBufferImpl>();
 
       return buffer.PassAs<GpuMemoryBufferImpl>();
     }
     default:
       return scoped_ptr<GpuMemoryBufferImpl>();
   }
 }
 
 }  // namespace content