Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Issue 2905653002: Updating the accessibility wording for the sign-in promo close button (Closed)

Created:
3 years, 7 months ago by jlebel
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating the accessibility wording for the sign-in promo close button Adding accessibility to the close button in sign-in promo BUG=661794 Review-Url: https://codereview.chromium.org/2905653002 Cr-Commit-Position: refs/heads/master@{#474274} Committed: https://chromium.googlesource.com/chromium/src/+/ddd554fbdbbcaa8a54cc01477e72b5f383c427ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
jlebel
Hello Sylvain, Can you review today this very small patch? Thanks,
3 years, 7 months ago (2017-05-24 13:32:16 UTC) #3
sdefresne
lgtm
3 years, 7 months ago (2017-05-24 13:35:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905653002/20001
3 years, 7 months ago (2017-05-24 13:35:22 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 13:47:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ddd554fbdbbcaa8a54cc01477e72...

Powered by Google App Engine
This is Rietveld 408576698