[arm] Fix memory leak in disassembler.

[arm] Fix memory leak in disassembler.

Which I introduced in:

c15b3ffc773ef7b14655b59b1ce1437de903fdc0 [arm] Share constant pool entries in snapshot.

BUG=chromium:725714
Review-Url: https://codereview.chromium.org/2905643002
Cr-Commit-Position: refs/heads/master@{#45540}
Committed: https://chromium.googlesource.com/v8/v8/+/db38b3c7f49b2c3eb054ae6f5a50c4c9e6f8afdb

[georgia.kouveli, 2017-05-24 11:24:45]

georgia.kouveli@arm.com changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org

[Jarin, 2017-05-24 11:50:53]

https://codereview.chromium.org/2905643002/diff/1/src/disassembler.cc
File src/disassembler.cc (right):

https://codereview.chromium.org/2905643002/diff/1/src/disassembler.cc#newcode278
src/disassembler.cc:278: delete it;
Is there any reason why it is a pointer? That is, why cannot you replace

RelocIterator* it = new RelocIterator(converter.code());

with

RelocIterator it(converter.code());

???

[georgia.kouveli, 2017-05-24 12:50:33]

On 2017/05/24 11:50:53, Jarin wrote:
> https://codereview.chromium.org/2905643002/diff/1/src/disassembler.cc
> File src/disassembler.cc (right):
> 
>
https://codereview.chromium.org/2905643002/diff/1/src/disassembler.cc#newcode278
> src/disassembler.cc:278: delete it;
> Is there any reason why it is a pointer? That is, why cannot you replace
> 
> RelocIterator* it = new RelocIterator(converter.code());
> 
> with
> 
> RelocIterator it(converter.code());
> 
> ???

Oops, not really, changed to not use a pointer, thanks! PTAL.

[Jarin, 2017-05-24 15:44:51]

lgtm (even though it would be even better if you renamed the variable 'it' to
something else, so that it does not shadow the other variable 'it' in the same
function.)

[georgia.kouveli, 2017-05-24 16:27:24]

On 2017/05/24 15:44:51, Jarin wrote:
> lgtm (even though it would be even better if you renamed the variable 'it' to
> something else, so that it does not shadow the other variable 'it' in the same
> function.)

Done.

[georgia.kouveli, 2017-05-26 12:23:21]

The CQ bit was checked by georgia.kouveli@arm.com

[georgia.kouveli, 2017-05-26 12:23:21]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2905643002/#ps40001
(title: "Rename iterator.")

[commit-bot: I haz the power, 2017-05-26 12:23:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 12:52:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495801401399860,
"parent_rev": "3c9b59899a7b6df83b4593b953408df8350114cd", "commit_rev":
"db38b3c7f49b2c3eb054ae6f5a50c4c9e6f8afdb"}

[commit-bot: I haz the power, 2017-05-26 12:53:03]

Description was changed from

==========
[arm] Fix memory leak in disassembler.

Which I introduced in:

c15b3ffc773ef7b14655b59b1ce1437de903fdc0 [arm] Share constant pool entries in
snapshot.

BUG=chromium:725714
==========

to

==========
[arm] Fix memory leak in disassembler.

Which I introduced in:

c15b3ffc773ef7b14655b59b1ce1437de903fdc0 [arm] Share constant pool entries in
snapshot.

BUG=chromium:725714

Review-Url: https://codereview.chromium.org/2905643002
Cr-Commit-Position: refs/heads/master@{#45540}
Committed:
https://chromium.googlesource.com/v8/v8/+/db38b3c7f49b2c3eb054ae6f5a50c4c9e6f...
==========

[commit-bot: I haz the power, 2017-05-26 12:53:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/db38b3c7f49b2c3eb054ae6f5a50c4c9e6f...