Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2905523003: Revert of Enforce constant size and device scale factor for surfaces (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enforce constant size and device scale factor for surfaces (patchset #16 id:800001 of https://codereview.chromium.org/2848223003/ ) Reason for revert: Suspect this breaks SurfaceAggregatorPerfTest BUG=725840 Original issue's description: > Enforce constant size and device scale factor for surfaces > > Surfaces are expected to have constant size and device scale factor but > we don't enforce that. This CL requires a valid SurfaceInfo to be > provided at the time of constructing a surface, and all frames that don't > match the SurfaceInfo will be skipped. > > TBR=sadrul@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2848223003 > Cr-Commit-Position: refs/heads/master@{#474050} > Committed: https://chromium.googlesource.com/chromium/src/+/5ba3188fa05666ae8d6031706c0963532f9d1457 TBR=fsamuel@chromium.org,danakj@chromium.org,piman@chromium.org,boliu@chromium.org,sadrul@chromium.org,samans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2905523003 Cr-Commit-Position: refs/heads/master@{#474280} Committed: https://chromium.googlesource.com/chromium/src/+/5cf9bd2b9e7713034d798e6aed304124d9a694fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -249 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M android_webview/browser/surfaces_instance.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M android_webview/browser/test/rendering_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support.h View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support.cc View 4 chunks +9 lines, -30 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support_unittest.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 10 chunks +5 lines, -16 lines 0 comments Download
M cc/surfaces/surface.h View 3 chunks +5 lines, -6 lines 0 comments Download
M cc/surfaces/surface.cc View 5 chunks +6 lines, -18 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 6 chunks +12 lines, -3 lines 0 comments Download
M cc/surfaces/surface_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_manager.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M cc/surfaces/surface_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/test/compositor_frame_helpers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/test_compositor_frame_sink.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 1 chunk +10 lines, -13 lines 0 comments Download
M components/viz/frame_sinks/gpu_compositor_frame_sink.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 35 chunks +40 lines, -45 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.cc View 4 chunks +12 lines, -25 lines 0 comments Download
M ui/android/delegated_frame_host_android.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ui/aura/local/compositor_frame_sink_local.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/local/compositor_frame_sink_local.cc View 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of Enforce constant size and device scale factor for surfaces
3 years, 7 months ago (2017-05-24 14:15:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905523003/1
3 years, 7 months ago (2017-05-24 14:15:51 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 14:17:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5cf9bd2b9e7713034d798e6aed30...

Powered by Google App Engine
This is Rietveld 408576698