Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 2905513002: Add missing dependency on exe_and_shlib_deps (Closed)

Created:
1 year, 9 months ago by Tom Anderson
Modified:
1 year, 9 months ago
Reviewers:
bradnelson
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dependency on exe_and_shlib_deps BUG=723069 R=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2905513002 Cr-Commit-Position: refs/heads/master@{#474160} Committed: https://chromium.googlesource.com/chromium/src/+/e449acf2a251e5130b41c2e69ab1bc7b6a534b48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/nacl_host/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Anderson
1 year, 9 months ago (2017-05-24 00:43:42 UTC) #3
bradnelson
lgtm
1 year, 9 months ago (2017-05-24 01:21:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905513002/1
1 year, 9 months ago (2017-05-24 03:55:01 UTC) #9
commit-bot: I haz the power
1 year, 9 months ago (2017-05-24 04:16:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e449acf2a251e5130b41c2e69ab1...

Powered by Google App Engine
This is Rietveld 408576698