Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2905493003: Rename StyleNonInheritedVariables::Copy to Clone. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename StyleNonInheritedVariables::Copy to Clone. This patch renames StyleNonInheritedVariables::Copy to Clone to match convention. BUG=628043 Review-Url: https://codereview.chromium.org/2905493003 Cr-Commit-Position: refs/heads/master@{#474610} Committed: https://chromium.googlesource.com/chromium/src/+/1a15411c6cb0dcc1d3108f00179ff88f8a7368f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/style/StyleNonInheritedVariables.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-24 03:11:53 UTC) #4
meade_UTC10
lgtm lol too easy
3 years, 7 months ago (2017-05-25 05:37:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905493003/1
3 years, 7 months ago (2017-05-25 06:03:37 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 08:53:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a15411c6cb0dcc1d3108f00179f...

Powered by Google App Engine
This is Rietveld 408576698