Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2905483003: Add setHandlingEvent method the headless_application for Mac (Closed)

Created:
3 years, 7 months ago by dvallet
Modified:
3 years, 7 months ago
Reviewers:
Sami
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add setHandlingEvent method the headless_application for Mac BUG=725381 Review-Url: https://codereview.chromium.org/2905483003 Cr-Commit-Position: refs/heads/master@{#474338} Committed: https://chromium.googlesource.com/chromium/src/+/17f99595be5cdb040a2db0d347f9723c704cc15c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M headless/lib/browser/headless_shell_application_mac.h View 1 chunk +5 lines, -1 line 0 comments Download
M headless/lib/browser/headless_shell_application_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dvallet
PTAL Note: this solves the crash issue, but e.g. some input elements like dropdowns use ...
3 years, 7 months ago (2017-05-24 02:56:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905483003/1
3 years, 7 months ago (2017-05-24 02:57:58 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-24 02:58:01 UTC) #6
Sami
lgtm.
3 years, 7 months ago (2017-05-24 17:27:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905483003/1
3 years, 7 months ago (2017-05-24 17:27:50 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 17:33:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17f99595be5cdb040a2db0d347f9...

Powered by Google App Engine
This is Rietveld 408576698