Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2905423002: Do not attempt to use data reduction proxy when holdback is enabled (Closed)

Created:
3 years, 6 months ago by tbansal1
Modified:
3 years, 6 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not attempt to use data reduction proxy when holdback is enabled BUG=726773 Review-Url: https://codereview.chromium.org/2905423002 Cr-Commit-Position: refs/heads/master@{#475723} Committed: https://chromium.googlesource.com/chromium/src/+/93fb0767a75b443bf25bc99b1b97f48f7b074ccd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 3 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
tbansal1
ryansturm: ptal. Thanks.
3 years, 6 months ago (2017-05-27 00:04:46 UTC) #3
RyanSturm
lgtm
3 years, 6 months ago (2017-05-30 23:39:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905423002/1
3 years, 6 months ago (2017-05-30 23:40:57 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 01:31:20 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/93fb0767a75b443bf25bc99b1b97...

Powered by Google App Engine
This is Rietveld 408576698