chrome/browser/resources/settings/settings_ui/settings_ui.js - Issue 2905393002: MD Settings: URL encode text queries before adding them to the URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2905393002: MD Settings: URL encode text queries before adding them to the URL. (Closed)

Patch Set: Nit. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_ui/settings_ui.js

diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js

index 20dde6a077414a3161372341a05ed00962af8cac..09c363c0d87f8eaa48c50b5d498ad919446cfbb4 100644

--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js

+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js

@@ -248,7 +248,9 @@ Polymer({

settings.navigateTo(

settings.Route.BASIC,

- query.length > 0 ? new URLSearchParams('search=' + query) : undefined,

+ query.length > 0 ?

+ new URLSearchParams('search=' + encodeURIComponent(query)) :

dpapad 2017/05/27 00:18:10 This is the only line necessary for the fix.

+ undefined,

/* removeSearch */ true);