MD Settings: URL encode text queries before adding them to the URL.

chrome/test/data/webui/settings/settings_ui_browsertest.js

Index: chrome/test/data/webui/settings/settings_ui_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_ui_browsertest.js b/chrome/test/data/webui/settings/settings_ui_browsertest.js
index be2201cb87dab76d4ef0c615591ed035a5421980..22813ab62c665a95b9d5fa9e7ea9e74e7af104f6 100644
--- a/chrome/test/data/webui/settings/settings_ui_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_ui_browsertest.js
@@ -133,6 +133,11 @@ TEST_F('SettingsUIBrowserTest', 'DISABLED_All', function() {
       var value = 'GOOG';
       searchField.setValue(value);
       assertEquals(value, settings.getQueryParameters().get('search'));
+
+      // Test that search queries are properly URL encoded.
+      value = '+++';
+      searchField.setValue(value);

[dschuyler, 2017/05/27 01:32:13]

wdyt of asserting that the internal value of searchField does  not  match the
local |value| var?

[dpapad, 2017/05/27 01:39:34]

That would not be correct (the internal value DOES match |value|). Its' the URL
that does not match (chrome://md-settings/?search=%2B%2B%2B). This is clearer if
you try the following in the dev console.

new URLSearchParams('search=' + '+++').get('search') // returns '   ' which is
wrong
new URLSearchParams('search=' + encodeURIComponent('+++')).get('search') //
returns '+++' which is right

Let me know if that did not answer your question (I am not sure).

[dschuyler, 2017/05/27 01:44:18]

Acknowledged.

+      assertEquals(value, settings.getQueryParameters().get('search'));

[dpapad, 2017/05/27 00:18:10]

I verified that this test would have caught the problem. Unfortunately though,
tests in this file are disabled above (see DISABLED_All). I'll look into
potentially re-enabling them in follow up CL.

     });
 
      test('whitespace only search query is ignored', function() {