Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2905333002: Separate out event-targeting logic in EventDispatcher to EventTargeter. (Closed)

Created:
3 years, 7 months ago by riajiang
Modified:
3 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate out event-targeting logic in EventDispatcher to EventTargeter. Create a new class EventTargeter responsible for finding the PointerTarget for an event or the DeepestWindow for a location, moving PointerTargetForEvent and FindDeepestVisibleWindowForEvents from EventDispatcher to EventTargeter. BUG=none, related to https://codereview.chromium.org/2884463002/. TEST=covered by tests Review-Url: https://codereview.chromium.org/2905333002 Cr-Commit-Position: refs/heads/master@{#475211} Committed: https://chromium.googlesource.com/chromium/src/+/73de84a84f1f7c8a4aa9e4b7b1816851df82d49b

Patch Set 1 #

Total comments: 2

Patch Set 2 : make unique #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -61 lines) Patch
M services/ui/ws/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/event_dispatcher.h View 1 2 6 chunks +3 lines, -30 lines 0 comments Download
M services/ui/ws/event_dispatcher.cc View 1 2 7 chunks +15 lines, -31 lines 0 comments Download
A services/ui/ws/event_targeter.h View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A services/ui/ws/event_targeter.cc View 1 2 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
riajiang
Hi, PTAL, thanks!
3 years, 7 months ago (2017-05-26 18:24:41 UTC) #2
sky
LGTM https://codereview.chromium.org/2905333002/diff/1/services/ui/ws/event_dispatcher.cc File services/ui/ws/event_dispatcher.cc (right): https://codereview.chromium.org/2905333002/diff/1/services/ui/ws/event_dispatcher.cc#newcode49 services/ui/ws/event_dispatcher.cc:49: event_targeter_(new EventTargeter(delegate_, &modal_window_controller_)), MakeUnique
3 years, 7 months ago (2017-05-26 19:53:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905333002/20001
3 years, 7 months ago (2017-05-26 21:06:39 UTC) #9
riajiang
https://codereview.chromium.org/2905333002/diff/1/services/ui/ws/event_dispatcher.cc File services/ui/ws/event_dispatcher.cc (right): https://codereview.chromium.org/2905333002/diff/1/services/ui/ws/event_dispatcher.cc#newcode49 services/ui/ws/event_dispatcher.cc:49: event_targeter_(new EventTargeter(delegate_, &modal_window_controller_)), On 2017/05/26 19:53:43, sky wrote: > ...
3 years, 7 months ago (2017-05-26 21:06:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/304686)
3 years, 7 months ago (2017-05-26 22:12:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905333002/40001
3 years, 7 months ago (2017-05-26 23:14:03 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-27 01:34:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/73de84a84f1f7c8a4aa9e4b7b181...

Powered by Google App Engine
This is Rietveld 408576698