Chromium Code Reviews
DescriptionReland of Fixes formatting of the signed-in setting string on iOS. (patchset #1 id:1 of https://codereview.chromium.org/2907883002/ )
Reason for revert:
Re-landing this. Seems like there was a check that was added right after my CL landed. That check was since reverted.
Original issue's description:
> Revert of Fixes formatting of the signed-in setting string on iOS. (patchset #4 id:100001 of https://codereview.chromium.org/2903273002/ )
>
> Reason for revert:
> Seems like this broke ios-simulator tests on the waterfall. Reverting and will re-land once fixed.
>
> Original issue's description:
> > Fixes formatting of the signed-in setting string on iOS.
> >
> > Also adds a test to ensure that that specific string gets formatted
> > properly.
> >
> > R=mahmadi@chromium.org, rouslan@chromium.org
> > BUG=602666
> >
> > Review-Url: https://codereview.chromium.org/2903273002 .
> > Cr-Commit-Position: refs/heads/master@{#474991}
> > Committed: https://chromium.googlesource.com/chromium/src/+/b2c5e5f71d6b747d62709c6f9c190c1380ce8976
>
> TBR=mahmadi@chromium.org,rouslan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=602666
>
> Review-Url: https://codereview.chromium.org/2907883002
> Cr-Commit-Position: refs/heads/master@{#475039}
> Committed: https://chromium.googlesource.com/chromium/src/+/f0787307c947b6c715656971be506e2bef8c01a8
TBR=mahmadi@chromium.org,rouslan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602666
Review-Url: https://codereview.chromium.org/2905323002
Cr-Commit-Position: refs/heads/master@{#475053}
Committed: https://chromium.googlesource.com/chromium/src/+/98902b021c59abf02d5545d686f741dd8a4b1119
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||