Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2905323002: Reland of Fixes formatting of the signed-in setting string on iOS. (Closed)

Created:
3 years, 7 months ago by macourteau
Modified:
3 years, 7 months ago
CC:
anthonyvd, chromium-reviews, gogerald+paymentswatch_chromium.org, ios-reviews_chromium.org, ios-reviews+chrome_chromium.org, mahmadi+paymentswatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, MAD
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fixes formatting of the signed-in setting string on iOS. (patchset #1 id:1 of https://codereview.chromium.org/2907883002/ ) Reason for revert: Re-landing this. Seems like there was a check that was added right after my CL landed. That check was since reverted. Original issue's description: > Revert of Fixes formatting of the signed-in setting string on iOS. (patchset #4 id:100001 of https://codereview.chromium.org/2903273002/ ) > > Reason for revert: > Seems like this broke ios-simulator tests on the waterfall. Reverting and will re-land once fixed. > > Original issue's description: > > Fixes formatting of the signed-in setting string on iOS. > > > > Also adds a test to ensure that that specific string gets formatted > > properly. > > > > R=mahmadi@chromium.org, rouslan@chromium.org > > BUG=602666 > > > > Review-Url: https://codereview.chromium.org/2903273002 . > > Cr-Commit-Position: refs/heads/master@{#474991} > > Committed: https://chromium.googlesource.com/chromium/src/+/b2c5e5f71d6b747d62709c6f9c190c1380ce8976 > > TBR=mahmadi@chromium.org,rouslan@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=602666 > > Review-Url: https://codereview.chromium.org/2907883002 > Cr-Commit-Position: refs/heads/master@{#475039} > Committed: https://chromium.googlesource.com/chromium/src/+/f0787307c947b6c715656971be506e2bef8c01a8 TBR=mahmadi@chromium.org,rouslan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602666 Review-Url: https://codereview.chromium.org/2905323002 Cr-Commit-Position: refs/heads/master@{#475053} Committed: https://chromium.googlesource.com/chromium/src/+/98902b021c59abf02d5545d686f741dd8a4b1119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M ios/chrome/browser/ui/payments/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_view_controller.mm View 2 chunks +4 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_view_controller_unittest.mm View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
macourteau
Created Reland of Fixes formatting of the signed-in setting string on iOS.
3 years, 7 months ago (2017-05-26 17:40:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905323002/1
3 years, 7 months ago (2017-05-26 17:41:32 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 17:44:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98902b021c59abf02d5545d686f7...

Powered by Google App Engine
This is Rietveld 408576698