Index: third_party/WebKit/Source/core/page/WindowFeatures.h |
diff --git a/third_party/WebKit/Source/core/page/WindowFeatures.h b/third_party/WebKit/Source/core/page/WindowFeatures.h |
index 7432c94d8d8d47e4b2d2f32e25585f2d1d6623f6..fd431550ccdd7efcd445f4e60bf06054a62a3a79 100644 |
--- a/third_party/WebKit/Source/core/page/WindowFeatures.h |
+++ b/third_party/WebKit/Source/core/page/WindowFeatures.h |
@@ -36,31 +36,10 @@ |
namespace blink { |
-class IntRect; |
- |
struct CORE_EXPORT WindowFeatures { |
DISALLOW_NEW(); |
- WindowFeatures() |
- : x(0), |
- x_set(false), |
- y(0), |
- y_set(false), |
- width(0), |
- width_set(false), |
- height(0), |
- height_set(false), |
- menu_bar_visible(true), |
- status_bar_visible(true), |
- tool_bar_visible(true), |
- location_bar_visible(true), |
- scrollbars_visible(true), |
- resizable(true), |
- fullscreen(false), |
- dialog(false), |
- noopener(false) {} |
+ WindowFeatures() : WindowFeatures(String()) {} |
explicit WindowFeatures(const String& window_features_string); |
- WindowFeatures(const String& dialog_features_string, |
Nate Chapin
2017/05/31 16:55:13
Unused.
|
- const IntRect& screen_available_rect); |
int x; |
bool x_set; |
@@ -74,28 +53,13 @@ struct CORE_EXPORT WindowFeatures { |
bool menu_bar_visible; |
bool status_bar_visible; |
bool tool_bar_visible; |
kinuko
2017/06/01 06:39:28
maybe rename this to tool_or_location_bar_visible,
Nate Chapin
2017/06/01 20:57:11
Done (in WebWindowFeatures.h)
|
- bool location_bar_visible; |
Nate Chapin
2017/05/31 16:55:13
This is *almost* unused on trunk: when deciding wh
|
bool scrollbars_visible; |
- bool resizable; |
- |
- bool fullscreen; |
- bool dialog; |
Nate Chapin
2017/05/31 16:55:13
resizable, fullscreen and dialog are all dead.
|
bool noopener; |
- |
- Vector<String> additional_features; |
Nate Chapin
2017/05/31 16:55:13
This is just used to detect background/persistent
|
+ bool background; |
+ bool persistent; |
kinuko
2017/06/01 06:39:28
By the way now that core/ can refer to public/web
Nate Chapin
2017/06/01 20:57:11
Moved the constructor logic to CreateWindow.cpp, a
|
private: |
- using DialogFeaturesMap = HashMap<String, String>; |
- static void ParseDialogFeatures(const String&, HashMap<String, String>&); |
- static bool BoolFeature(const DialogFeaturesMap&, |
- const char* key, |
- bool default_value = false); |
- static int IntFeature(const DialogFeaturesMap&, |
Nate Chapin
2017/05/31 16:55:13
All this private stuff was just for the unused con
|
- const char* key, |
- int min, |
- int max, |
- int default_value); |
void SetWindowFeature(const String& key_string, const String& value_string); |
}; |