Remove a bunch of dead code around WindowFeatures

third_party/WebKit/Source/core/page/WindowFeatures.h

 /*
  * Copyright (C) 2003, 2007, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 18 matching lines @@
 #ifndef WindowFeatures_h
 #define WindowFeatures_h
 
 #include "core/CoreExport.h"
 #include "platform/wtf/Allocator.h"
 #include "platform/wtf/HashMap.h"
 #include "platform/wtf/text/WTFString.h"
 
 namespace blink {
 
-class IntRect;
-
 struct CORE_EXPORT WindowFeatures {
   DISALLOW_NEW();
-  WindowFeatures()
-      : x(0),
-        x_set(false),
-        y(0),
-        y_set(false),
-        width(0),
-        width_set(false),
-        height(0),
-        height_set(false),
-        menu_bar_visible(true),
-        status_bar_visible(true),
-        tool_bar_visible(true),
-        location_bar_visible(true),
-        scrollbars_visible(true),
-        resizable(true),
-        fullscreen(false),
-        dialog(false),
-        noopener(false) {}
+  WindowFeatures() : WindowFeatures(String()) {}
   explicit WindowFeatures(const String& window_features_string);
-  WindowFeatures(const String& dialog_features_string,

[Nate Chapin, 2017/05/31 16:55:13]

Unused.

-                 const IntRect& screen_available_rect);
 
   int x;
   bool x_set;
   int y;
   bool y_set;
   int width;
   bool width_set;
   int height;
   bool height_set;
 
   bool menu_bar_visible;
   bool status_bar_visible;
   bool tool_bar_visible;

[kinuko, 2017/06/01 06:39:28]

maybe rename this to tool_or_location_bar_visible, or add a short comment about
that, to unconfuse readers?

[Nate Chapin, 2017/06/01 20:57:11]

Done (in WebWindowFeatures.h)

-  bool location_bar_visible;

[Nate Chapin, 2017/05/31 16:55:13]

This is *almost* unused on trunk: when deciding whether to treat a new window as
a popup or a new tab, we use a popup if either tool_bar_visible or
location_bar_visible are true. Instead, just use tool_bar_visible and set it to
true if either is present in the feature string.

   bool scrollbars_visible;
-  bool resizable;
-
-  bool fullscreen;
-  bool dialog;

[Nate Chapin, 2017/05/31 16:55:13]

resizable, fullscreen and dialog are all dead.

 
   bool noopener;
-
-  Vector<String> additional_features;

[Nate Chapin, 2017/05/31 16:55:13]

This is just used to detect background/persistent in RenderViewImpl. Detect them
during initial parse.

+  bool background;
+  bool persistent;

[kinuko, 2017/06/01 06:39:28]

By the way now that core/ can refer to public/web I feel we might be able to
just use WebWindowFeatures here (as a composition or just merge these two),
would it work?

[Nate Chapin, 2017/06/01 20:57:11]

Moved the constructor logic to CreateWindow.cpp, and dropped
WindowFeatures.h/cpp

 
  private:
-  using DialogFeaturesMap = HashMap<String, String>;
-  static void ParseDialogFeatures(const String&, HashMap<String, String>&);
-  static bool BoolFeature(const DialogFeaturesMap&,
-                          const char* key,
-                          bool default_value = false);
-  static int IntFeature(const DialogFeaturesMap&,

[Nate Chapin, 2017/05/31 16:55:13]

All this private stuff was just for the unused constructor.

-                        const char* key,
-                        int min,
-                        int max,
-                        int default_value);
   void SetWindowFeature(const String& key_string, const String& value_string);
 };
 
 }  // namespace blink
 
 #endif  // WindowFeatures_h