third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2905283003: Remove a bunch of dead code around WindowFeatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)

Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 3dfa0a38658bc8eda5484c587ddc9a7187093135..d2a43826a27ede175932b51a58c9c65bbec71816 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -3573,7 +3573,7 @@ void WebViewImpl::SetDomainRelaxationForbidden(bool forbidden,

}

void WebViewImpl::SetWindowFeatures(const WebWindowFeatures& features) {

- page_->GetChromeClient().SetWindowFeatures(features);

+ page_->SetWindowFeatures(features);

}

void WebViewImpl::SetOpenedByDOM() {