Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: third_party/WebKit/Source/core/page/WindowFeaturesTest.cpp

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/WindowFeaturesTest.cpp
diff --git a/third_party/WebKit/Source/core/page/WindowFeaturesTest.cpp b/third_party/WebKit/Source/core/page/WindowFeaturesTest.cpp
index 40798fd070853824bd62a169b00b57156ff58d7f..47633aa5d77ad51ddc99753fd7271a673186b63f 100644
--- a/third_party/WebKit/Source/core/page/WindowFeaturesTest.cpp
+++ b/third_party/WebKit/Source/core/page/WindowFeaturesTest.cpp
@@ -2,10 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
-#include "core/page/WindowFeatures.h"
+#include "core/page/CreateWindow.h"
#include <gtest/gtest.h>
#include "platform/wtf/text/WTFString.h"
+#include "public/web/WebWindowFeatures.h"
namespace blink {
@@ -27,8 +28,8 @@ TEST_F(WindowFeaturesTest, NoOpener) {
};
for (const auto& test : kCases) {
- WindowFeatures features(test.feature_string);
- EXPECT_EQ(test.noopener, features.noopener)
+ EXPECT_EQ(test.noopener,
+ GetWindowFeaturesFromString(test.feature_string).noopener)
<< "Testing '" << test.feature_string << "'";
}
}

Powered by Google App Engine
This is Rietveld 408576698