Remove a bunch of dead code around WindowFeatures

third_party/WebKit/Source/core/page/Page.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 25 matching lines @@
 #include "core/page/PageVisibilityObserver.h"
 #include "core/page/PageVisibilityState.h"
 #include "platform/Supplementable.h"
 #include "platform/geometry/LayoutRect.h"
 #include "platform/geometry/Region.h"
 #include "platform/heap/Handle.h"
 #include "platform/wtf/Forward.h"
 #include "platform/wtf/HashSet.h"
 #include "platform/wtf/Noncopyable.h"
 #include "platform/wtf/text/WTFString.h"
+#include "public/web/WebWindowFeatures.h"

[dcheng, 2017/06/02 18:46:22]

I'm not actually sure what the rules are on #including web things from core now.
I guess we consider this OK?

(In the past, this would have to move to platform)

[Nate Chapin, 2017/06/02 20:20:23]

kinuko suggested it in https://codereview.chromium.org/2905283003/#msg20 and
core/DEPS blesses it without commenting on restrictions, so I guess it's OK,
too?

I haven't been able to find any documentation of the decision.

 
 namespace blink {
 
 class AutoscrollController;
 class BrowserControls;
 class ChromeClient;
 class ClientRectList;
 class ContextMenuClient;
 class ContextMenuController;
 class Document;
@@ skipping 122 matching lines @@
   ScrollingCoordinator* GetScrollingCoordinator();
 
   ClientRectList* NonFastScrollableRects(const LocalFrame*);
 
   Settings& GetSettings() const { return *settings_; }
 
   UseCounter& GetUseCounter() { return use_counter_; }
   Deprecation& GetDeprecation() { return deprecation_; }
   HostsUsingFeatures& GetHostsUsingFeatures() { return hosts_using_features_; }
 
+  void SetWindowFeatures(const WebWindowFeatures& features) {
+    window_features_ = features;
+  }
+  const WebWindowFeatures& GetWindowFeatures() const {
+    return window_features_;
+  }
+
   PageScaleConstraintsSet& GetPageScaleConstraintsSet();
   const PageScaleConstraintsSet& GetPageScaleConstraintsSet() const;
 
   BrowserControls& GetBrowserControls();
   const BrowserControls& GetBrowserControls() const;
 
   ConsoleMessageStorage& GetConsoleMessageStorage();
   const ConsoleMessageStorage& GetConsoleMessageStorage() const;
 
   EventHandlerRegistry& GetEventHandlerRegistry();
@@ skipping 128 matching lines @@
 
   Member<PluginData> plugin_data_;
 
   EditorClient* const editor_client_;
   SpellCheckerClient* const spell_checker_client_;
   Member<ValidationMessageClient> validation_message_client_;
 
   UseCounter use_counter_;
   Deprecation deprecation_;
   HostsUsingFeatures hosts_using_features_;
+  WebWindowFeatures window_features_;
 
   bool opened_by_dom_;
   // Set to true when window.close() has been called and the Page will be
   // destroyed. The browsing contexts in this page should no longer be
   // discoverable via JS.
   // TODO(dcheng): Try to remove |DOMWindow::m_windowIsClosing| in favor of
   // this. However, this depends on resolving https://crbug.com/674641
   bool is_closing_;
 
   bool tab_key_cycles_through_elements_;
@@ skipping 10 matching lines @@
 #endif
 
   int subframe_count_;
 };
 
 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>;
 
 }  // namespace blink
 
 #endif  // Page_h