Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2905283003: Remove a bunch of dead code around WindowFeatures (Closed)
Patch Set: Use WebWindowFeatures everywhere Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 301fc74f0f9783133b98628ae9bb3dde2ea8d8cd..8ae484085f6a3b831d75bf4317c9be527ba8b875 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -528,29 +528,10 @@ class AlwaysDrawSwapPromise : public cc::SwapPromise {
ui::LatencyInfo latency_info_;
};
-const char kWindowFeatureBackground[] = "background";
-const char kWindowFeaturePersistent[] = "persistent";
-
content::mojom::WindowContainerType WindowFeaturesToContainerType(
const blink::WebWindowFeatures& window_features) {
- bool background = false;
- bool persistent = false;
-
- for (size_t i = 0; i < window_features.additional_features.size(); ++i) {
- blink::WebString feature = window_features.additional_features[i];
- if (feature.ContainsOnlyASCII()) {
- std::string featureASCII = feature.Ascii();
- if (base::LowerCaseEqualsASCII(featureASCII, kWindowFeatureBackground)) {
- background = true;
- } else if (base::LowerCaseEqualsASCII(featureASCII,
- kWindowFeaturePersistent)) {
- persistent = true;
- }
- }
- }
-
- if (background) {
- if (persistent)
+ if (window_features.background) {
+ if (window_features.persistent)
return content::mojom::WindowContainerType::PERSISTENT;
else
return content::mojom::WindowContainerType::BACKGROUND;

Powered by Google App Engine
This is Rietveld 408576698