WARN_UNUSED_RESULT on all Thread/SequenceChecker impls

WARN_UNUSED_RESULT on all Thread/SequenceChecker impls

Discovered a few unused NonThreadSafe::CalledOnValidThread() while
migrating away from it. Thankfully Thread/SequenceChecker already have
WARN_UNUSED_RESULT on their main impl. Coalesce a bit further to have it
everywhere.

BUG=676387
Review-Url: https://codereview.chromium.org/2905213002
Cr-Commit-Position: refs/heads/master@{#475040}
Committed: https://chromium.googlesource.com/chromium/src/+/e66aa55947422665d6fddaad94610ac8fc271d79

[gab, 2017-05-26 00:02:30]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-26 00:02:40]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2017-05-26 00:02:40]

Dana PTaL and CQ, thanks

[commit-bot: I haz the power, 2017-05-26 00:03:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 02:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 02:06:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[gab, 2017-05-26 03:51:43]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 03:52:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 07:44:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 07:44:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[danakj, 2017-05-26 15:50:46]

LGTM

[danakj, 2017-05-26 15:51:05]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-05-26 15:51:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 17:21:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495813865228290, "parent_rev":
"f0787307c947b6c715656971be506e2bef8c01a8", "commit_rev":
"e66aa55947422665d6fddaad94610ac8fc271d79"}

[commit-bot: I haz the power, 2017-05-26 17:21:15]

Description was changed from

==========
WARN_UNUSED_RESULT on all Thread/SequenceChecker impls

Discovered a few unused NonThreadSafe::CalledOnValidThread() while
migrating away from it. Thankfully Thread/SequenceChecker already have
WARN_UNUSED_RESULT on their main impl. Coalesce a bit further to have it
everywhere.

BUG=676387
==========

to

==========
WARN_UNUSED_RESULT on all Thread/SequenceChecker impls

Discovered a few unused NonThreadSafe::CalledOnValidThread() while
migrating away from it. Thankfully Thread/SequenceChecker already have
WARN_UNUSED_RESULT on their main impl. Coalesce a bit further to have it
everywhere.

BUG=676387

Review-Url: https://codereview.chromium.org/2905213002
Cr-Commit-Position: refs/heads/master@{#475040}
Committed:
https://chromium.googlesource.com/chromium/src/+/e66aa55947422665d6fddaad9461...
==========

[commit-bot: I haz the power, 2017-05-26 17:21:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e66aa55947422665d6fddaad9461...