Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2905203002: Make TextIndentLine an enum class. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, shans, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextIndentLine an enum class. This patch makes TextIndentLine an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2905203002 Cr-Commit-Position: refs/heads/master@{#474904} Committed: https://chromium.googlesource.com/chromium/src/+/9649896c27726c71e0b8015b73b24c9d0387626b

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
shend
Hi Alan, PTAL
3 years, 6 months ago (2017-05-25 23:59:45 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-05-26 01:52:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905203002/1
3 years, 6 months ago (2017-05-26 04:12:42 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 04:17:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9649896c27726c71e0b8015b73b2...

Powered by Google App Engine
This is Rietveld 408576698