Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issue 2905153002: Move off of deprecated base::NonThreadSafe in device/ (Closed)

Created:
3 years, 7 months ago by gab
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move off of deprecated base::NonThreadSafe in device/ BUG=676387 Review-Url: https://codereview.chromium.org/2905153002 Cr-Commit-Position: refs/heads/master@{#475368} Committed: https://chromium.googlesource.com/chromium/src/+/f03b5126e924f11cca9e5cc2243d29d861fc52b8

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : ThreadChecker => SequenceChecker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -54 lines) Patch
M device/serial/serial_io_handler.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M device/serial/serial_io_handler.cc View 1 2 9 chunks +12 lines, -12 lines 0 comments Download
M device/serial/serial_io_handler_posix.cc View 1 2 7 chunks +8 lines, -8 lines 0 comments Download
M device/serial/serial_io_handler_win.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M device/usb/usb_service.h View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M device/usb/usb_service.cc View 1 2 5 chunks +8 lines, -7 lines 0 comments Download
M device/usb/usb_service_impl.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M device/usb/usb_service_linux.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M device/usb/usb_service_win.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
gab
Reilly PTaL, thanks!
3 years, 7 months ago (2017-05-25 21:45:50 UTC) #5
Reilly Grant (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-26 00:52:38 UTC) #13
Reilly Grant (use Gerrit)
A sequence checker would also work here.
3 years, 7 months ago (2017-05-26 00:53:45 UTC) #14
gab
On 2017/05/26 00:53:45, Reilly Grant wrote: > A sequence checker would also work here. Thanks, ...
3 years, 6 months ago (2017-05-29 17:44:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905153002/80001
3 years, 6 months ago (2017-05-29 17:44:58 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 18:44:50 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f03b5126e924f11cca9e5cc2243d...

Powered by Google App Engine
This is Rietveld 408576698