Initialize a default feature policy for all documents

Initialize a default feature policy for all documents

This corrects an issue where certain documents, which are created without going through DocumentLoader, have no feature policy set at all. This was causing crashes when other frames were created inside of those documents.

BUG=722333
Review-Url: https://codereview.chromium.org/2905113002
Cr-Commit-Position: refs/heads/master@{#475141}
Committed: https://chromium.googlesource.com/chromium/src/+/f89ec5976eeb8455c011b0f9e349b9c3d7194524

[iclelland, 2017-05-25 19:01:11]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 19:01:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 19:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 19:12:41]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[iclelland, 2017-05-25 19:29:47]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 19:30:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 19:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 19:41:37]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[iclelland, 2017-05-26 02:44:00]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 02:44:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 02:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 02:54:44]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[iclelland, 2017-05-26 16:27:12]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 16:27:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2017-05-26 18:04:56]

Description was changed from

==========
Initialize a default feature policy for all documents

BUG=722333
==========

to

==========
Initialize a default feature policy for all documents

This corrects an issue where certain documents, which are created without going
through DocumentLoader, have no feature policy set at all. This was causing
crashes when other frames were created inside of those documents.

BUG=722333
==========

[iclelland, 2017-05-26 18:04:57]

iclelland@chromium.org changed reviewers:
+ jbroman@chromium.org

[iclelland, 2017-05-26 18:07:00]

+r jbroman -- would you mind taking a look at this? The other fix for the
immediate cause of the crash is in
https://chromium-review.googlesource.com/c/505434/, but this CL should restore
the assumption that documents have policies when created.

[commit-bot: I haz the power, 2017-05-26 18:20:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 18:20:36]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-05-26 18:33:16]

This lgtm, but a reviewer with more familiarity with how security contexts
relate to document lifetime might have more insight.

https://codereview.chromium.org/2905113002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2905113002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:5679: for (auto& message :
messages) {
nit: prefer "const auto&" where possible

https://codereview.chromium.org/2905113002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:5697: SetFeaturePolicy("");
super-nit: g_empty_string is slightly more efficient than "", here and below

[iclelland, 2017-05-26 19:14:26]

https://codereview.chromium.org/2905113002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2905113002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:5679: for (auto& message :
messages) {
On 2017/05/26 18:33:16, jbroman wrote:
> nit: prefer "const auto&" where possible

Done.

https://codereview.chromium.org/2905113002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:5697: SetFeaturePolicy("");
On 2017/05/26 18:33:16, jbroman wrote:
> super-nit: g_empty_string is slightly more efficient than "", here and below

Done (both instances).

[iclelland, 2017-05-26 19:14:45]

+cc tkent for visibility

[iclelland, 2017-05-26 19:14:49]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2017-05-26 19:14:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2905113002/#ps70001
(title: "Nits")

[commit-bot: I haz the power, 2017-05-26 19:15:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:23:52]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[iclelland, 2017-05-26 19:49:22]

The CQ bit was checked by iclelland@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:49:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:38:08]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1495828162277590,
"parent_rev": "bc6d9edaa73346babb63e558fbed7f17ad9a6e7f", "commit_rev":
"f89ec5976eeb8455c011b0f9e349b9c3d7194524"}

[commit-bot: I haz the power, 2017-05-26 21:38:21]

Description was changed from

==========
Initialize a default feature policy for all documents

This corrects an issue where certain documents, which are created without going
through DocumentLoader, have no feature policy set at all. This was causing
crashes when other frames were created inside of those documents.

BUG=722333
==========

to

==========
Initialize a default feature policy for all documents

This corrects an issue where certain documents, which are created without going
through DocumentLoader, have no feature policy set at all. This was causing
crashes when other frames were created inside of those documents.

BUG=722333

Review-Url: https://codereview.chromium.org/2905113002
Cr-Commit-Position: refs/heads/master@{#475141}
Committed:
https://chromium.googlesource.com/chromium/src/+/f89ec5976eeb8455c011b0f9e349...
==========

[commit-bot: I haz the power, 2017-05-26 21:38:22]

Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/f89ec5976eeb8455c011b0f9e349...