Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2905073002: Revert of Redirecting off-origin navigations in PWAs to CCT. (Closed)

Created:
3 years, 7 months ago by Moe
Modified:
3 years, 7 months ago
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Redirecting off-origin navigations in PWAs to CCT. (patchset #14 id:580001 of https://codereview.chromium.org/2829943002/ ) Reason for revert: This CL is likely the culprit for test failures: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/42079 https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/42080 https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/42081 Original issue's description: > Redirects off-origin navigations in an installed PWAs to a CustomTab. > > This is done in order to improve UX by getting rid of a "minibar" toolbar > (to be done in a follow-up patch) and bring more app-like feel to PWAs. > > In a long run this will help bring implementation of Minimal-UI, which requires > replacing "minibar" with a new "minimal-ui" toolbar. > > BUG=709889 > > Review-Url: https://codereview.chromium.org/2829943002 > Cr-Commit-Position: refs/heads/master@{#474625} > Committed: https://chromium.googlesource.com/chromium/src/+/7c7e9e600d256af4d2af1dbf68b59b030be0ab25 TBR=dominickn@chromium.org,yusufo@chromium.org,pkotwicz@chromium.org,tedchoc@chromium.org,piotrs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=709889 Review-Url: https://codereview.chromium.org/2905073002 Cr-Commit-Position: refs/heads/master@{#474647} Committed: https://chromium.googlesource.com/chromium/src/+/477e5841d63d6d2b7e548ac51a06e90d6915e72c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -397 lines) Patch
M chrome/android/java/AndroidManifest.xml View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInterceptNavigationDelegate.java View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 1 chunk +13 lines, -13 lines 0 comments Download
M chrome/android/java_sources.gni View 3 chunks +0 lines, -3 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TopActivityListener.java View 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java View 5 chunks +3 lines, -45 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestRule.java View 2 chunks +4 lines, -11 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java View 1 chunk +0 lines, -168 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/contextmenu/ContextMenuUtils.java View 3 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Moe
Created Revert of Redirecting off-origin navigations in PWAs to CCT.
3 years, 7 months ago (2017-05-25 14:31:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905073002/1
3 years, 7 months ago (2017-05-25 14:32:03 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 14:32:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/477e5841d63d6d2b7e548ac51a06...

Powered by Google App Engine
This is Rietveld 408576698