Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2905043004: Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, nasko+codewatch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC. This should only be set by browser-initiated navigations. BUG=726142 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/bad_message.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jam
3 years, 7 months ago (2017-05-26 01:32:16 UTC) #9
nasko
Let's add a test for this, just to make sure we don't regress it accidentally. ...
3 years, 7 months ago (2017-05-26 15:51:43 UTC) #12
jam
On 2017/05/26 15:51:43, nasko wrote: > Let's add a test for this, just to make ...
3 years, 7 months ago (2017-05-26 15:53:22 UTC) #13
nasko
3 years, 7 months ago (2017-05-26 16:25:43 UTC) #14
On 2017/05/26 15:53:22, jam wrote:
> On 2017/05/26 15:51:43, nasko wrote:
> > Let's add a test for this, just to make sure we don't regress it
accidentally.
> > It is easy to do using PwnMessageReceived.
> 
> (per IM, let's do this asynchronously from this cl)

https://codereview.chromium.org/2905293002

Powered by Google App Engine
This is Rietveld 408576698