Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2905043003: [headless] Fix window management browsertests on Mac. (Closed)

Created:
3 years, 7 months ago by Eric Seckler
Modified:
3 years, 6 months ago
Reviewers:
Sami
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Fix window management browsertests on Mac. For now, simply disable the failing expectations for window positions. BUG=726288 Review-Url: https://codereview.chromium.org/2905043003 Cr-Commit-Position: refs/heads/master@{#474623} Committed: https://chromium.googlesource.com/chromium/src/+/f4fde3627fa302b702440da6d6aec9522708c40b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M headless/lib/headless_devtools_client_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Eric Seckler
Sami, PTAL :)
3 years, 7 months ago (2017-05-25 10:12:43 UTC) #6
Sami
lgtm, thanks!
3 years, 7 months ago (2017-05-25 10:53:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905043003/40001
3 years, 7 months ago (2017-05-25 11:03:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f4fde3627fa302b702440da6d6aec9522708c40b
3 years, 7 months ago (2017-05-25 11:08:53 UTC) #14
jzfeng
3 years, 6 months ago (2017-05-26 00:51:58 UTC) #15
Message was sent while issue was closed.
On 2017/05/25 11:08:53, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/f4fde3627fa302b702440da6d6ae...

Thanks for fixing the failing tests!

Powered by Google App Engine
This is Rietveld 408576698