Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2905043002: Make DocumentOrderedMap take a const reference for scope (Closed)

Created:
3 years, 7 months ago by hayato
Modified:
3 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DocumentOrderedMap take a const reference for scope This CL has no behavior changes. Review-Url: https://codereview.chromium.org/2905043002 Cr-Commit-Position: refs/heads/master@{#474597} Committed: https://chromium.googlesource.com/chromium/src/+/933dc3199a9418e3c5b1d14d681d976867e8e4f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentOrderedMap.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp View 5 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 4 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
hayato
PTAL
3 years, 7 months ago (2017-05-25 05:27:08 UTC) #4
tkent
lgtm
3 years, 7 months ago (2017-05-25 05:32:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905043002/1
3 years, 7 months ago (2017-05-25 05:41:24 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 07:08:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/933dc3199a9418e3c5b1d14d681d...

Powered by Google App Engine
This is Rietveld 408576698