Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2905033003: Stricter equality check for local refs in CSSURIValue (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stricter equality check for local refs in CSSURIValue 'local' references ("#foo") needn't even consider the absolute URL(s) when being compared. In this particular case, the (redundant) comparison ended up comparing equal because a base-URL-less parser context is used when parsing the property (will be fixed separately.) When |is_local_| is set, only consider the relative URLs during the comparison. BUG=725469 Review-Url: https://codereview.chromium.org/2905033003 Cr-Commit-Position: refs/heads/master@{#474717} Committed: https://chromium.googlesource.com/chromium/src/+/77584b488e6f147a4a0b5d75a1ceda38ff80dd08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/svg/animations/animate-local-url.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/animations/animate-local-url-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSURIValue.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
fs
3 years, 7 months ago (2017-05-25 17:20:16 UTC) #4
Stephen Chennney
On 2017/05/25 17:20:16, fs wrote: LGTM. Thanks for the quick turnaround.
3 years, 7 months ago (2017-05-25 18:02:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905033003/1
3 years, 7 months ago (2017-05-25 18:27:19 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 18:33:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77584b488e6f147a4a0b5d75a1ce...

Powered by Google App Engine
This is Rietveld 408576698