Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2905023002: Remove WTFLogAlways() usages from platform/graphics/ (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
index 99229a013de5112f1a441b962747188779e123a5..8cbb5116a7306fdaed53cce8685d6718fea1a1e2 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
@@ -287,10 +287,11 @@ void PaintController::ProcessNewItem(DisplayItem& display_item) {
if (index != kNotFound) {
#ifndef NDEBUG
ShowDebugData();
- WTFLogAlways(
- "DisplayItem %s has duplicated id with previous %s (index=%zu)\n",
- display_item.AsDebugString().Utf8().data(),
- new_display_item_list_[index].AsDebugString().Utf8().data(), index);
+ LOG(INFO) << "\n"
tkent 2017/06/14 23:27:11 Does DisplayItem::AsDebugString() produces multi-l
+ << "DisplayItem " << display_item.AsDebugString().Utf8().data()
tkent 2017/06/14 23:27:11 probably we should change DisplayItem::AsDebugStri
+ << " has duplicated id with previous "
+ << new_display_item_list_[index].AsDebugString().Utf8().data()
+ << " (index=" << index << ")\n";
tkent 2017/06/14 23:27:11 The trailing \n is unnecessary.
#endif
NOTREACHED();
}
@@ -961,8 +962,9 @@ void PaintController::CheckUnderInvalidation() {
}
void PaintController::ShowDebugDataInternal(bool show_paint_records) const {
- WTFLogAlways("current display item list: [%s]\n",
- current_paint_artifact_.GetDisplayItemList()
+ LOG(INFO) << "\n"
+ << "current display item list: ["
+ << current_paint_artifact_.GetDisplayItemList()
.SubsequenceAsJSON(
0, current_paint_artifact_.GetDisplayItemList().size(),
show_paint_records
@@ -970,22 +972,25 @@ void PaintController::ShowDebugDataInternal(bool show_paint_records) const {
: DisplayItemList::JsonOptions::kDefault)
->ToPrettyJSONString()
.Utf8()
- .data());
+ .data()
+ << "]\n";
tkent 2017/06/14 23:27:11 The trailing \n is unnecessary.
// debugName() and clientCacheIsValid() can only be called on a live
// client, so only output it for m_newDisplayItemList, in which we are
// sure the clients are all alive.
- WTFLogAlways(
- "new display item list: [%s]\n",
- new_display_item_list_
- .SubsequenceAsJSON(
- 0, new_display_item_list_.size(),
- show_paint_records
- ? (DisplayItemList::JsonOptions::kShowPaintRecords |
- DisplayItemList::JsonOptions::kShowClientDebugName)
- : DisplayItemList::JsonOptions::kShowClientDebugName)
- ->ToPrettyJSONString()
- .Utf8()
- .data());
+ LOG(INFO)
+ << "\n"
+ << "new display item list: ["
+ << new_display_item_list_
+ .SubsequenceAsJSON(
+ 0, new_display_item_list_.size(),
+ show_paint_records
+ ? (DisplayItemList::JsonOptions::kShowPaintRecords |
+ DisplayItemList::JsonOptions::kShowClientDebugName)
+ : DisplayItemList::JsonOptions::kShowClientDebugName)
+ ->ToPrettyJSONString()
+ .Utf8()
+ .data()
+ << "]\n";
tkent 2017/06/14 23:27:11 The trailing \n is unnecessary.
}
void PaintController::SetFirstPainted() {

Powered by Google App Engine
This is Rietveld 408576698