Remove WTFLogAlways() usages from platform/graphics/

third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/PaintController.h"
 
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/graphics/paint/DrawingDisplayItem.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "platform/wtf/AutoReset.h"
@@ skipping 269 matching lines @@
     if (begin_display_item.IsBegin() && !begin_display_item.DrawsContent())
       DCHECK(!display_item.IsEndAndPairedWith(begin_display_item.GetType()));
   }
 
   size_t index = FindMatchingItemFromIndex(display_item.GetId(),
                                            new_display_item_indices_by_client_,
                                            new_display_item_list_);
   if (index != kNotFound) {
 #ifndef NDEBUG
     ShowDebugData();
-    WTFLogAlways(
-        "DisplayItem %s has duplicated id with previous %s (index=%zu)\n",
-        display_item.AsDebugString().Utf8().data(),
-        new_display_item_list_[index].AsDebugString().Utf8().data(), index);
+    LOG(INFO) << "\n"

[tkent, 2017/06/14 23:27:11]

Does DisplayItem::AsDebugString() produces multi-line string? If not, I think we
don't need to add the leading "\n".

+              << "DisplayItem " << display_item.AsDebugString().Utf8().data()

[tkent, 2017/06/14 23:27:11]

probably we should change DisplayItem::AsDebugString() to operator<<().

+              << " has duplicated id with previous "
+              << new_display_item_list_[index].AsDebugString().Utf8().data()
+              << " (index=" << index << ")\n";

[tkent, 2017/06/14 23:27:11]

The trailing \n is unnecessary.

 #endif
     NOTREACHED();
   }
   AddItemToIndexIfNeeded(display_item, new_display_item_list_.size() - 1,
                          new_display_item_indices_by_client_);
 #endif  // DCHECK_IS_ON()
 
   if (RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled())
     CheckUnderInvalidation();
 
@@ skipping 650 matching lines @@
   // non-under-invalidation-checking path to empty the original cached slot,
   // leaving only disappeared or invalidated display items in the old list after
   // painting.
   new_display_item_list_.RemoveLast();
   MoveItemFromCurrentListToNewList(old_item_index);
 
   ++under_invalidation_checking_begin_;
 }
 
 void PaintController::ShowDebugDataInternal(bool show_paint_records) const {
-  WTFLogAlways("current display item list: [%s]\n",
-               current_paint_artifact_.GetDisplayItemList()
+  LOG(INFO) << "\n"
+            << "current display item list: ["
+            << current_paint_artifact_.GetDisplayItemList()
                    .SubsequenceAsJSON(
                        0, current_paint_artifact_.GetDisplayItemList().size(),
                        show_paint_records
                            ? DisplayItemList::JsonOptions::kShowPaintRecords
                            : DisplayItemList::JsonOptions::kDefault)
                    ->ToPrettyJSONString()
                    .Utf8()
-                   .data());
+                   .data()
+            << "]\n";

[tkent, 2017/06/14 23:27:11]

The trailing \n is unnecessary.

   // debugName() and clientCacheIsValid() can only be called on a live
   // client, so only output it for m_newDisplayItemList, in which we are
   // sure the clients are all alive.
-  WTFLogAlways(
-      "new display item list: [%s]\n",
-      new_display_item_list_
-          .SubsequenceAsJSON(
-              0, new_display_item_list_.size(),
-              show_paint_records
-                  ? (DisplayItemList::JsonOptions::kShowPaintRecords |
-                     DisplayItemList::JsonOptions::kShowClientDebugName)
-                  : DisplayItemList::JsonOptions::kShowClientDebugName)
-          ->ToPrettyJSONString()
-          .Utf8()
-          .data());
+  LOG(INFO)
+      << "\n"
+      << "new display item list: ["
+      << new_display_item_list_
+             .SubsequenceAsJSON(
+                 0, new_display_item_list_.size(),
+                 show_paint_records
+                     ? (DisplayItemList::JsonOptions::kShowPaintRecords |
+                        DisplayItemList::JsonOptions::kShowClientDebugName)
+                     : DisplayItemList::JsonOptions::kShowClientDebugName)
+             ->ToPrettyJSONString()
+             .Utf8()
+             .data()
+      << "]\n";

[tkent, 2017/06/14 23:27:11]

The trailing \n is unnecessary.

 }
 
 void PaintController::SetFirstPainted() {
   frame_first_paints_.back().first_painted = true;
 }
 
 void PaintController::SetTextPainted() {
   frame_first_paints_.back().text_painted = true;
 }
 
 void PaintController::SetImagePainted() {
   frame_first_paints_.back().image_painted = true;
 }
 
 void PaintController::BeginFrame(const void* frame) {
   frame_first_paints_.push_back(FrameFirstPaint(frame));
 }
 
 FrameFirstPaint PaintController::EndFrame(const void* frame) {
   FrameFirstPaint result = frame_first_paints_.back();
   DCHECK(result.frame == frame);
   frame_first_paints_.pop_back();
   return result;
 }
 
 }  // namespace blink