Remove WTFLogAlways() usages from platform/graphics/

Remove WTFLogAlways() usages from platform/graphics/

Use LOG(INFO) instead.

BUG=638849
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[mrunal, 2017-05-25 02:38:23]

Description was changed from

==========
Remove WTFLogAlways() usages from platform/graphics/

Use LOG(INFO) instead.

BUG=638849
==========

to

==========
Remove WTFLogAlways() usages from platform/graphics/

Use LOG(INFO) instead.

BUG=638849
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[mrunal, 2017-05-25 02:41:06]

The CQ bit was checked by mrunal.kapade@intel.com to run a CQ dry run

[mrunal, 2017-05-25 02:41:36]

Description was changed from

==========
Remove WTFLogAlways() usages from platform/graphics/

Use LOG(INFO) instead.

BUG=638849
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove WTFLogAlways() usages from platform/graphics/

Use LOG(INFO) instead.

BUG=638849
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[mrunal, 2017-05-25 02:41:36]

mrunal.kapade@intel.com changed reviewers:
+ pdr@chromium.org, tkent@chromium.org

[commit-bot: I haz the power, 2017-05-25 02:42:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 04:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:47:32]

Dry run: This issue passed the CQ dry run.

[mrunal, 2017-06-14 19:00:43]

tkent/pdr, can you PTAL?

[tkent, 2017-06-14 23:27:11]

I'd like to defer review to platform/graphics/OWNERS.

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp (right):

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp:921: LOG(INFO) <<
"\n"
Use DLOG().  LOG() usage should be avoided.

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp:922: <<
RecordAsDebugString(record, bounds).Utf8().data() << "\n";
The trailing \n is unnecessary.

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:290:
LOG(INFO) << "\n"
Does DisplayItem::AsDebugString() produces multi-line string? If not, I think we
don't need to add the leading "\n".

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:291: <<
"DisplayItem " << display_item.AsDebugString().Utf8().data()
probably we should change DisplayItem::AsDebugString() to operator<<().

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:294: << "
(index=" << index << ")\n";
The trailing \n is unnecessary.

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:976: <<
"]\n";
The trailing \n is unnecessary.

https://codereview.chromium.org/2905023002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:993: <<
"]\n";
The trailing \n is unnecessary.

[gyuyoung, 2017-07-18 06:45:06]

@mrunal, any update on this ? If not, I'd like to handle this issue on Issue
2968633002 instead.

[mrunal, 2017-07-24 19:29:13]

Sorry for the long pause on this but I have incorporated the suggested changes
in this new patch.

On 2017/07/18 06:45:06, gyuyoung wrote:
> @mrunal, any update on this ? If not, I'd like to handle this issue on Issue
> 2968633002 instead.

Looking at your changes they look similar to mine so I will go ahead and make
the suggested changes here instead. Otherwise I would have transferred this to
you.

[gyuyoung, 2017-08-02 05:03:38]

Informal LGTM.

[Stephen Chennney, 2017-08-02 13:23:43]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2017-08-02 13:23:45]

Also be aware that this review system is being deprecated in favor of gerrit.

https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp (right):

https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp:921: DLOG(INFO) <<
"\n" << RecordAsDebugString(record, bounds).Utf8().data();
The newline is not required at all. DLOG inserts it for you.

And String, the thing returned by RecordAsDebugString, has an operator<< so you
do not need the .Utf8().data().

These comments apply to almost all the changes you have proposed.

https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):

https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:293: << "
(index=" << index << ")";
Same issue with unnecessary .Utf8().data()

https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:975: <<
"]";
Ditto.

https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:992: <<
"]";
Ditto.

[mrunal, 2017-08-04 18:53:49]

On 2017/08/02 13:23:45, Stephen Chennney wrote:
> Also be aware that this review system is being deprecated in favor of gerrit.
> 
>
https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp (right):
> 
>
https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp:921: DLOG(INFO)
<<
> "\n" << RecordAsDebugString(record, bounds).Utf8().data();
> The newline is not required at all. DLOG inserts it for you.
> 
> And String, the thing returned by RecordAsDebugString, has an operator<< so
you
> do not need the .Utf8().data().
> 
> These comments apply to almost all the changes you have proposed.
> 
>
https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
> (right):
> 
>
https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:293: <<
"
> (index=" << index << ")";
> Same issue with unnecessary .Utf8().data()
> 
>
https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:975: <<
> "]";
> Ditto.
> 
>
https://codereview.chromium.org/2905023002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:992: <<
> "]";
> Ditto.

Done. PTAL.

[mrunal, 2017-09-21 22:51:00]

Closing this issue as it was fixed here,
https://chromium-review.googlesource.com/c/chromium/src/+/675599