Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2905013004: Speed up LayoutTests/fast/text/find-backwards.html (Closed)

Created:
3 years, 7 months ago by eae
Modified:
3 years, 7 months ago
Reviewers:
dgrogan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Speed up LayoutTests/fast/text/find-backwards.html Speed up the fast/text/find-backwards.html layout test and convert it to use the new web platform test testharness. BUG=725588 R=dgrogan@chromium.org Review-Url: https://codereview.chromium.org/2905013004 Cr-Commit-Position: refs/heads/master@{#474821} Committed: https://chromium.googlesource.com/chromium/src/+/98a2c5c6af2a6b5d0d81cb846e8bdaf66da7dae9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -110 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/find-backwards.html View 1 chunk +83 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/find-backwards-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/script-tests/find-backwards.js View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
eae
3 years, 7 months ago (2017-05-25 21:05:19 UTC) #1
dgrogan
What's the secret sauce here -- where does the speedup come from? That's where I'll ...
3 years, 7 months ago (2017-05-25 21:10:54 UTC) #4
eae
On 2017/05/25 21:10:54, dgrogan wrote: > What's the secret sauce here -- where does the ...
3 years, 7 months ago (2017-05-25 21:11:48 UTC) #5
dgrogan
lgtm
3 years, 7 months ago (2017-05-25 21:54:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905013004/1
3 years, 7 months ago (2017-05-25 22:00:27 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 22:30:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98a2c5c6af2a6b5d0d81cb846e8b...

Powered by Google App Engine
This is Rietveld 408576698