chromeos: changes how DisplayManagerObservers are notified

chromeos: changes how DisplayManagerObservers are notified

This patch makes it such that in manual display mode (controlled via
WindowManagerWindowTreeFactory) DisplayManagerObservers are only
notified when the WindowManager calls
SetDisplayConfiguration(). Having a separate function allows the
WindowManager to add/remove displays and then trigger notifying
client. This is necessary so that the clients see a consistent state.

BUG=706589
TEST=covered by tests
R=erg@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2904993003
Cr-Commit-Position: refs/heads/master@{#475076}
Committed: https://chromium.googlesource.com/chromium/src/+/2771709f0236929814545a8738053b227d44a170

[sky, 2017-05-25 17:49:38]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 17:50:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 17:54:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:54:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2017-05-25 19:42:32]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 19:42:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 20:54:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 20:54:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-05-26 14:12:44]

tsepez: mojom
erg: the rest

[Tom Sepez, 2017-05-26 16:41:43]

lgtm

[Elliot Glaysher, 2017-05-26 17:13:17]

lgtm

[sky, 2017-05-26 17:48:10]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-26 17:48:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2904993003/#ps10042
(title: "cleanup")

[commit-bot: I haz the power, 2017-05-26 17:48:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:04:10]

CQ is committing da patch.

Bot data: {"patchset_id": 10042, "attempt_start_ts": 1495820890848180,
"parent_rev": "13eace280f457bc0c065f05a415dc02b07fbb9af", "commit_rev":
"2771709f0236929814545a8738053b227d44a170"}

[commit-bot: I haz the power, 2017-05-26 19:04:23]

Description was changed from

==========
chromeos: changes how DisplayManagerObservers are notified

This patch makes it such that in manual display mode (controlled via
WindowManagerWindowTreeFactory) DisplayManagerObservers are only
notified when the WindowManager calls
SetDisplayConfiguration(). Having a separate function allows the
WindowManager to add/remove displays and then trigger notifying
client. This is necessary so that the clients see a consistent state.

BUG=706589
TEST=covered by tests
R=erg@chromium.org, tsepez@chromium.org
==========

to

==========
chromeos: changes how DisplayManagerObservers are notified

This patch makes it such that in manual display mode (controlled via
WindowManagerWindowTreeFactory) DisplayManagerObservers are only
notified when the WindowManager calls
SetDisplayConfiguration(). Having a separate function allows the
WindowManager to add/remove displays and then trigger notifying
client. This is necessary so that the clients see a consistent state.

BUG=706589
TEST=covered by tests
R=erg@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2904993003
Cr-Commit-Position: refs/heads/master@{#475076}
Committed:
https://chromium.googlesource.com/chromium/src/+/2771709f0236929814545a873805...
==========

[commit-bot: I haz the power, 2017-05-26 19:04:26]

Committed patchset #5 (id:10042) as
https://chromium.googlesource.com/chromium/src/+/2771709f0236929814545a873805...