Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2904983004: media: Fix CDM path in CdmAdapterFactory (Closed)

Created:
3 years, 7 months ago by xhwang
Modified:
3 years, 7 months ago
Reviewers:
jrummell
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix CDM path in CdmAdapterFactory This is a followup CL of 79fc0eff0e3bf95ad6a9759a49d9c837781440f8. On mac, the CDM is actually located in the framework bundle. In the future, the path will be passed in from the browser, and we don't need to calculate the path in this class. BUG=561090 Review-Url: https://codereview.chromium.org/2904983004 Cr-Commit-Position: refs/heads/master@{#474827} Committed: https://chromium.googlesource.com/chromium/src/+/71152a313182c322cbd8efee51f4217dab044881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M media/cdm/cdm_adapter_factory.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
xhwang
PTAL
3 years, 7 months ago (2017-05-25 22:02:37 UTC) #4
jrummell
lgtm
3 years, 7 months ago (2017-05-25 22:32:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904983004/1
3 years, 7 months ago (2017-05-25 22:33:52 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 22:40:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71152a313182c322cbd8efee51f4...

Powered by Google App Engine
This is Rietveld 408576698