Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2904933004: [Notifications] Forward mouse wheel events. (Closed)

Created:
3 years, 7 months ago by Eliot Courtney
Modified:
3 years, 7 months ago
Reviewers:
yoshiki, yhanada
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org, xiyuan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Notifications] Forward mouse wheel events. This fixes a regression where we can't scroll the message center when the mouse is over ARC notifications. BUG=726574 Review-Url: https://codereview.chromium.org/2904933004 Cr-Commit-Position: refs/heads/master@{#474898} Committed: https://chromium.googlesource.com/chromium/src/+/dbe2894b5f9fc7b0d480eefe879e8cb5d087d71c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Eliot Courtney
PTAL~! Thanks.
3 years, 7 months ago (2017-05-25 04:39:57 UTC) #3
yoshiki
Could you associate this with a bug number? Then LGTM.
3 years, 7 months ago (2017-05-25 16:20:23 UTC) #7
Eliot Courtney
3 years, 7 months ago (2017-05-26 03:18:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904933004/1
3 years, 7 months ago (2017-05-26 03:23:45 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 03:29:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbe2894b5f9fc7b0d480eefe879e...

Powered by Google App Engine
This is Rietveld 408576698