LayoutObject::AbsoluteBoundingBoxRectForRange() should take EphemeralRange

LayoutObject::AbsoluteBoundingBoxRectForRange() should take EphemeralRange

Currently LayoutObject::AbsoluteBoundingBoxRectForRange uses range object
to calculate ComputeTextQuads which takes EphemeralRange.
LayoutObject::absoluteBoundingBoxRectForRange should take EphemeralRange,
as LayoutObject are owned by DOM.

BUG=691198
Review-Url: https://codereview.chromium.org/2904833002
Cr-Commit-Position: refs/heads/master@{#474584}
Committed: https://chromium.googlesource.com/chromium/src/+/93cfe464269ec0fb00d8c118b7b3a49fdf712a56

[tanvir, 2017-05-24 07:55:16]

Description was changed from

==========
LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

 Currently LayoutObject::absoluteBoundingBoxRectForRange uses Range object
 to calculate textQuads which takes EphemeralRange.
 LayoutObject::absoluteBoundingBoxRectForRange should take EphemeralRange,
 as Layoutobject are owned by DOM.

 BUG=691198
==========

to

==========
LayoutObject::AbsoluteBoundingBoxRectForRange() should take EphemeralRange

Currently LayoutObject::AbsoluteBoundingBoxRectForRange uses range object
to calculate ComputeTextQuads which takes EphemeralRange.
LayoutObject::absoluteBoundingBoxRectForRange should take EphemeralRange,
as LayoutObject are owned by DOM.

BUG=691198
==========

[tanvir, 2017-05-24 09:22:59]

tanvir.rizvi@samsung.com changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[tanvir, 2017-05-24 09:22:59]

PTAL!!!
Thank you!

[yosin_UTC9, 2017-05-24 09:31:37]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 09:32:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 09:34:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 09:34:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yosin_UTC9, 2017-05-24 09:35:51]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-05-24 09:35:52]

lgtm

Thanks for working this!
Using EphemeralRange make Blink faster!

+tkent@ for core/layout and web/ chagnes.

https://codereview.chromium.org/2904833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FindInPageCoordinates.cpp (right):

https://codereview.chromium.org/2904833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FindInPageCoordinates.cpp:153: const
LayoutObject* baseLayoutObject =
nit: s/const LayoutObject*/const LayoutObject* const/

[yosin_UTC9, 2017-05-24 09:36:45]

Please rebase.

[tanvir, 2017-05-24 14:17:41]

Patch is rebased.
PTAL.
Thanks

[tkent, 2017-05-24 23:02:43]

lgtm

[yosin_UTC9, 2017-05-25 04:47:33]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-25 04:47:34]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2904833002/#ps60001
(title: "RebasedAndUpdatedWithComments")

[commit-bot: I haz the power, 2017-05-25 04:48:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 06:32:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495687653669510,
"parent_rev": "d9e6b495633f4f1382309dff618aa41af04413ee", "commit_rev":
"93cfe464269ec0fb00d8c118b7b3a49fdf712a56"}

[commit-bot: I haz the power, 2017-05-25 06:32:20]

Description was changed from

==========
LayoutObject::AbsoluteBoundingBoxRectForRange() should take EphemeralRange

Currently LayoutObject::AbsoluteBoundingBoxRectForRange uses range object
to calculate ComputeTextQuads which takes EphemeralRange.
LayoutObject::absoluteBoundingBoxRectForRange should take EphemeralRange,
as LayoutObject are owned by DOM.

BUG=691198
==========

to

==========
LayoutObject::AbsoluteBoundingBoxRectForRange() should take EphemeralRange

Currently LayoutObject::AbsoluteBoundingBoxRectForRange uses range object
to calculate ComputeTextQuads which takes EphemeralRange.
LayoutObject::absoluteBoundingBoxRectForRange should take EphemeralRange,
as LayoutObject are owned by DOM.

BUG=691198

Review-Url: https://codereview.chromium.org/2904833002
Cr-Commit-Position: refs/heads/master@{#474584}
Committed:
https://chromium.googlesource.com/chromium/src/+/93cfe464269ec0fb00d8c118b7b3...
==========

[commit-bot: I haz the power, 2017-05-25 06:32:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/93cfe464269ec0fb00d8c118b7b3...