Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 2904833002: LayoutObject::AbsoluteBoundingBoxRectForRange() should take EphemeralRange (Closed)

Created:
3 years, 7 months ago by tanvir
Modified:
3 years, 7 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutObject::AbsoluteBoundingBoxRectForRange() should take EphemeralRange Currently LayoutObject::AbsoluteBoundingBoxRectForRange uses range object to calculate ComputeTextQuads which takes EphemeralRange. LayoutObject::absoluteBoundingBoxRectForRange should take EphemeralRange, as LayoutObject are owned by DOM. BUG=691198 Review-Url: https://codereview.chromium.org/2904833002 Cr-Commit-Position: refs/heads/master@{#474584} Committed: https://chromium.googlesource.com/chromium/src/+/93cfe464269ec0fb00d8c118b7b3a49fdf712a56

Patch Set 1 #

Patch Set 2 : updaredPatch #

Total comments: 1

Patch Set 3 : updatedPS #

Patch Set 4 : RebasedAndUpdatedWithComments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M third_party/WebKit/Source/core/editing/FindInPageCoordinates.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FindInPageCoordinates.cpp View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 1 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
tanvir
PTAL!!! Thank you!
3 years, 7 months ago (2017-05-24 09:22:59 UTC) #3
yosin_UTC9
lgtm Thanks for working this! Using EphemeralRange make Blink faster! +tkent@ for core/layout and web/ ...
3 years, 7 months ago (2017-05-24 09:35:52 UTC) #9
yosin_UTC9
Please rebase.
3 years, 7 months ago (2017-05-24 09:36:45 UTC) #10
tanvir
Patch is rebased. PTAL. Thanks
3 years, 7 months ago (2017-05-24 14:17:41 UTC) #11
tkent
lgtm
3 years, 7 months ago (2017-05-24 23:02:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904833002/60001
3 years, 7 months ago (2017-05-25 04:48:05 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 06:32:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/93cfe464269ec0fb00d8c118b7b3...

Powered by Google App Engine
This is Rietveld 408576698